Skip to content

[Python O11Y] Fix core header dependency issue - #35845

Closed
XuanWang-Amos wants to merge 1 commit into
grpc:masterfrom
XuanWang-Amos:fix_o11y_core_header_deps
Closed

[Python O11Y] Fix core header dependency issue#35845
XuanWang-Amos wants to merge 1 commit into
grpc:masterfrom
XuanWang-Amos:fix_o11y_core_header_deps

Conversation

@XuanWang-Amos

@XuanWang-Amos XuanWang-Amos commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Core team moved resolver code to src/core/resolver, our build is failing because we have a dependency on it and the resolver folder is not copied to observability/grpc_root:

  • call_tracer.h -> core_configuration.h -> lb_policy_registry.h -> lb_policy.h -> endpoint_addresses.h

To fix this issue and to prevent such issues from happening again, instead of subfolders, we'll copy all files from src/core to observability/grpc_root/src/core.

Artifact Size:

@XuanWang-Amos XuanWang-Amos added the release notes: no Indicates if PR should not be in release notes label Feb 7, 2024
@XuanWang-Amos
XuanWang-Amos requested a review from gnossen February 7, 2024 19:18
@XuanWang-Amos
XuanWang-Amos marked this pull request as ready for review February 7, 2024 19:19
@gnossen

gnossen commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

How do we get this dependency? Can you give me the pathway in terms of C++ files?

@XuanWang-Amos

Copy link
Copy Markdown
Contributor Author

How do we get this dependency? Can you give me the pathway in terms of C++ files?

It's in the description.

@copybara-service copybara-service Bot closed this in 6028810 Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/Python release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants