[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log - #36584
Closed
tanvi-jagtap wants to merge 1 commit into
Closed
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log#36584tanvi-jagtap wants to merge 1 commit into
tanvi-jagtap wants to merge 1 commit into
Conversation
tanvi-jagtap
added
the
release notes: no
tanvi-jagtap
marked this pull request as ready for review
May 11, 2024 04:33
grpc-checks
Bot
added
bloat/low
per-call-memory/neutral
per-channel-memory/neutral
labels
tanvi-jagtap
requested review from
ananda1066 and
sastryvp
and removed request for
sastryvp
May 11, 2024 04:54
ananda1066
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log
In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.
We have the following mapping
Reviewers need to check :
gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.