AP Photo quickfix#4741
Merged
Merged
Conversation
andrew-nowak
approved these changes
May 15, 2026
gu-prout
Bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-auth
Seen-on-leases
and removed
Pending-on-leases
Pending-on-media-api
Pending-on-metadata-editor
Pending-on-kahuna
Pending-on-auth
labels
|
Seen on auth, metadata-editor, leases, media-api, kahuna (merged by @paperboyo 8 minutes and 47 seconds ago) Please check your changes! |
|
Seen on collections, image-loader, thrall, cropper (merged by @paperboyo 8 minutes and 53 seconds ago) Please check your changes! |
|
Seen on usage (merged by @paperboyo 9 minutes and 7 seconds ago) Please check your changes! |
|
Seen on usage (merged by @paperboyo 9 minutes and 8 seconds ago) Please check your changes! |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our friends changed how they credit images. It’s better now. And we were warned. Slightly late and without examples, but still. This is a quick fix for first party AP images. By my rough calculation this (
search?query=uploader:ap credit:"AP Photo") is gonna fix two thirds of images. For the remaining on third (search?query=uploader:ap -credit:"AP Photo"), the proper fix is this #4664. Yes, that proper fix can be stripped down, most probably. But I’m not gonna be the one doing that, no Sir, because I don’t think that would be correct. 😛Who should look at this?
@guardian/newsroom-resilience
Tested? Documented?