Skip to content

Match on AP intermediaries, retain them in Credit and write them into Supplier Collection#4742

Merged
paperboyo merged 2 commits into
mainfrom
mk-ap-quickfix-intermediaries
May 18, 2026
Merged

Match on AP intermediaries, retain them in Credit and write them into Supplier Collection#4742
paperboyo merged 2 commits into
mainfrom
mk-ap-quickfix-intermediaries

Conversation

@paperboyo
Copy link
Copy Markdown
Contributor

@paperboyo paperboyo commented May 15, 2026

Co-authored by Claude Opus 4.6. Description written by a human, 48.

What does this change?

This is a followup to #4741. It:

  • matches on …/AP credits, writing prefixes into Supplier Collection and retaining original Credit line
  • removes redundant Invision-specific matcher
  • removes outdated test that can’t happen now we have BylineCreditReorganiser (and other) cleaners

Worth noting that it will retain some credits we will want to clean more. Mostly, the ones mentioning Pool in all sorts of combinations, but also some other redundant or ugly things. Proper fix from here will clean them better (and remove redundant Description blobs too).

How can success be measured?

AP images from third-party intermediaries are recognised correctly

Who should look at this?

@guardian/newsroom-resilience

Tested? Documented?

  • locally by committer
  • locally by Guardian reviewer
  • on the Guardian's TEST environment
  • relevant documentation added or amended (if needed)

@paperboyo paperboyo requested a review from a team as a code owner May 15, 2026 10:23
@paperboyo paperboyo added the fix Departmental tracking: fix label May 15, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

Co-authored-by: paperboyo <mateusz.karpow@guardian.co.uk>
Copy link
Copy Markdown
Contributor

@bryophyta bryophyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been through the behaviour and verified that it works as @paperboyo expects

@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented May 18, 2026

Seen on image-loader, cropper (merged by @paperboyo 9 minutes and 57 seconds ago) Please check your changes!

@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented May 18, 2026

Seen on usage, media-api (merged by @paperboyo 10 minutes and 2 seconds ago) Please check your changes!

@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented May 18, 2026

Seen on kahuna (merged by @paperboyo 10 minutes and 6 seconds ago) Please check your changes!

@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented May 18, 2026

Seen on metadata-editor, collections, leases (merged by @paperboyo 10 minutes and 14 seconds ago) Please check your changes!

2 similar comments
@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented May 18, 2026

Seen on metadata-editor, collections, leases (merged by @paperboyo 10 minutes and 14 seconds ago) Please check your changes!

@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented May 18, 2026

Seen on metadata-editor, collections, leases (merged by @paperboyo 10 minutes and 14 seconds ago) Please check your changes!

@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented May 18, 2026

Seen on thrall (merged by @paperboyo 12 minutes and 6 seconds ago) Please check your changes!

@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented May 18, 2026

Seen on auth (merged by @paperboyo 12 minutes and 12 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants