Skip to content

Upgrade the amazon sdk libs#4745

Merged
lindseydew merged 3 commits into
mainfrom
ld/upgrade-amazon-sdk
May 28, 2026
Merged

Upgrade the amazon sdk libs#4745
lindseydew merged 3 commits into
mainfrom
ld/upgrade-amazon-sdk

Conversation

@lindseydew

@lindseydew lindseydew commented May 21, 2026

Copy link
Copy Markdown
Contributor

What does this change?

This upgrades the amazon sdk libs

How should a reviewer test this change?

How can success be measured?

Who should look at this?

Tested? Documented?

  • locally by committer
  • locally by Guardian reviewer
  • on the Guardian's TEST environment
  • relevant documentation added or amended (if needed)

@lindseydew lindseydew requested a review from a team as a code owner May 21, 2026 10:58
@lindseydew lindseydew added the dependencies Pull requests that update a dependency file label May 21, 2026
@lindseydew lindseydew marked this pull request as draft May 21, 2026 11:27
@lindseydew

lindseydew commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

Converting to draft because the build is broken

lindseydew
lindseydew commented May 28, 2026
View reviewed changes
Comment thread common-lib/src/main/scala/com/gu/mediaservice/lib/aws/SimpleSqsMessageConsumer.scala
.withWaitTimeSeconds(20) // Wait for maximum duration (20s) as per doc recommendation: http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-long-polling.html
.withMaxNumberOfMessages(1) // Pull 1 message at a time to avoid starvation
.withAttributeNames(attributeNames: _*)
.withMessageSystemAttributeNames(attributeNames: _*)

@lindseydew lindseydew May 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the docs:
This parameter has been deprecated but will be supported for backward compatibility. To provide attribute names, you are encouraged to use MessageSystemAttributeNames.

@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown

Deploy build 14500 of media-service::grid::all to TEST

All deployment options

From guardian/actions-riff-raff.

@lindseydew lindseydew marked this pull request as ready for review May 28, 2026 10:31
@lindseydew lindseydew merged commit be8e03b into main May 28, 2026
7 checks passed
@lindseydew lindseydew deleted the ld/upgrade-amazon-sdk branch May 28, 2026 10:47
@gu-prout

gu-prout Bot commented May 28, 2026

Copy link
Copy Markdown

Seen on auth, image-loader, cropper, kahuna (merged by @lindseydew 9 minutes and 11 seconds ago) Please check your changes!

@gu-prout

gu-prout Bot commented May 28, 2026

Copy link
Copy Markdown

Seen on thrall, leases, media-api (merged by @lindseydew 9 minutes and 16 seconds ago) Please check your changes!

@gu-prout

gu-prout Bot commented May 28, 2026

Copy link
Copy Markdown

Seen on collections (merged by @lindseydew 9 minutes and 31 seconds ago) Please check your changes!

@gu-prout

gu-prout Bot commented May 28, 2026

Copy link
Copy Markdown

Seen on metadata-editor (merged by @lindseydew 9 minutes and 48 seconds ago) Please check your changes!

@gu-prout

gu-prout Bot commented May 28, 2026

Copy link
Copy Markdown

Seen on usage (merged by @lindseydew 11 minutes and 18 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew-nowak andrew-nowak andrew-nowak approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file Seen-on-auth Seen-on-collections Seen-on-cropper Seen-on-image-loader Seen-on-kahuna Seen-on-leases Seen-on-media-api Seen-on-metadata-editor Seen-on-thrall Seen-on-usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lindseydew @andrew-nowak