Upgrade S3 - Part 6 - #4836
Merged
Merged
Conversation
lindseydew
added
the
maintenance
twrichards
approved these changes
Jul 28, 2026
| @@ -241,6 +241,7 @@ class ImageLoaderController(auth: Authentication, | |||
|
|
|||
| def getPreSignedUploadUrlsAndTrack: Action[AnyContent] = AuthenticatedAndAuthorised.async { request => | |||
| val expiration = DateTimeUtils.now().plusHours(1) | |||
Contributor
There was a problem hiding this comment.
is expiration still used at all, given it's no longer used in the preSignedUrl bit further down... if not please can it be removed... if it is still in use, please can signatureDuration be defined first and then expiration calculated by adding signatureDuration to DateTimeUtils.now()
Contributor
Author
There was a problem hiding this comment.
It's used to set the status in the a dynamo table:
gu-prout
Bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
and removed
Pending-on-cropper
Pending-on-leases
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-usage
Pending-on-kahuna
labels
|
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, kahuna (merged by @lindseydew 10 minutes and 19 seconds ago) Please check your changes! |
gu-prout
Bot
added
Seen-on-media-api
Seen-on-collections
and removed
Pending-on-media-api
Pending-on-collections
labels
|
Seen on collections, media-api (merged by @lindseydew 12 minutes and 33 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This migrates more of the s3 methods in image loader
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?