merge from original#2
Merged
Merged
Conversation
Some DB’s don’t define an instance, so verify the setting has no effect for them.
Additional testing for split-by-instance config
Run JmxFetch app as a daemon
Alpha version of Jetty 10 was released and it seems to be compiled for java versions above 8 so tests fail on java8. Limit latest dep Jetty tests to Jetty 9 for now.
Alpha version of Jetty 10 was released and it seems to be compiled for java versions above 8 so tests fail on java8. Limit latest dep Jetty tests to Jetty 9 for now.
Avoid Jetty 10
It’s not very interesting and breaks the definition of “instance” when we want to see the db name when no instance name is defined.
This is useful to temporarily remove a trace from scope for a defined period.
It doesn't look like it is doing anything useful but instead it seems to set version in resulting build jar which is not expected.
Remove version from gradle wrapper definition
Remove default instance
Since toString(), equals(), and hashCode() are never called, the code coverage for the classes are too low. In the future, we should ignore code coverage of lombok generated methods
DDTraceOTInfo wasn't the best place for container information. Changed ContainerInfo.java to have a static instance
Container ID Tagging
Instrumentation of Google Http Client
Minor javadoc fix
Assert span in scope can't be null and add tests to verify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.