Enable explain-open in Codex - #204
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The updated docs and path-validation logic introduce (and then mask) a Codex-specific ~/.agents/skills/... reference that conflicts with the repo’s canonical cross-skill path convention and risks hiding future path typos.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR enables the explain-open skill for Codex by removing it from Codex’s excluded skills list, updating its documentation to cover Codex usage, and extending installer / skill-path validation tests to account for the newly-shipped skill.
Changes:
- Removes
explain-openfromai/codex/excluded-skills.txtso Codex installs it. - Updates
ai/skills/explain-open/SKILL.mdto document Codex invocation and artifact lookup flow. - Extends installer and canonical-skill tests to account for
explain-openbeing present.
File summaries
| File | Description |
|---|---|
| ai/tests/test-canonical-skills.sh | Adjusts SKILL.md path-scanning to ignore certain absolute references during validation. |
| ai/tests/test-ai-installers.sh | Adds an assertion that Codex installs explain-open. |
| ai/skills/explain-open/SKILL.md | Updates skill documentation for Codex usage and review-artifact lookup. |
| ai/codex/excluded-skills.txt | Removes explain-open from Codex exclusions so it becomes installable. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+171
to
+175
| # Drop supported absolute references first: their tails look exactly like relative ones, and | ||
| # scanning for both at once reports every cross-skill path as a missing local file. | ||
| body=$(sed 's#~/\.dotfiles/[A-Za-z0-9._/-]*##g' "$skill_file") | ||
| body=$(sed -E \ | ||
| -e 's#~/\.dotfiles/[A-Za-z0-9._/-]*##g' \ | ||
| -e 's#~/\.agents/skills/review-code/[A-Za-z0-9._/-]*##g' \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
explain-openfor Codex and documents$explain-openinvocation.review-codeskill path and covers installation and path validation.Test plan
ai/tests/test-ai-installers.shai/tests/test-canonical-skills.shai/tests/test-skill-spec.sh