Skip to content
This repository was archived by the owner on Mar 18, 2026. It is now read-only.

Pull pcb-trophy project into repositor - #533

Merged
maxwofford merged 21 commits into
hackclub:mainfrom
roy-rishi:main
May 10, 2024
Merged

Pull pcb-trophy project into repositor#533
maxwofford merged 21 commits into
hackclub:mainfrom
roy-rishi:main

Conversation

@roy-rishi

Copy link
Copy Markdown
Contributor

Submission Checklist:

  • I am a current high school, middle school, or home schooled student.

  • I have joined the #electronics channel on Slack

  • I made this board from scratch, even if I followed a tutorial

  • I have followed the directions in README.md

    • Created a folder under onboard/projects
    • Filled out TEMPLATE.md as README.md
    • Uploaded Gerber.zip and Schematic.pdf
    • Created a folder called src and uploaded design files
    • Uploaded screenshot of PCB order with all costs included
    • I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)
  • (Optional) This project is from a tutorial1.

  • (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials.

@prophetorpheus

prophetorpheus commented May 5, 2024

Copy link
Copy Markdown
Collaborator
Hi, I'm Orpheus Leap! Here to help you review your PR.

projects/pcb-trophy:

Required files

README.md A description of your project
cart.png cart.png
gerber.zip
schematic.pdf Manually check schematic.pdf
Source files - Unknown No source files found. Please make a directory called 'src' and put your gerbers and upload your source files there. There must be two files, one for the schematic and one for the PCB. .

You can view a render of your board over on gerber.zip/2d!

Happy OnBoarding!
This bot is a simpler helper for common submission types. If there's an error with this, please point it out and someone from the OnBoard team will look at it manually.

@maxwofford maxwofford left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! I'm a little surprised at how expensive shipping is though– there might be a cheaper option. Also, have you double checked your battery has enough current to handle that many LEDs in parallel?

@maxwofford

Copy link
Copy Markdown
Member

I just marked it as "requested changes" for now– your verification is approved and I'll send the grant if there's no cheaper option & the LEDs are fine with the battery.

@maxwofford maxwofford added the Submission New Boards! label May 7, 2024
@maxwofford maxwofford self-assigned this May 7, 2024
@roy-rishi

Copy link
Copy Markdown
Contributor Author

Hey Max, thanks for reviewing my PR. Shipping surprised me too; I believe it's due to the 1-1.5 kg mass of all 5 PCBs. There is one slightly cheaper option, however the timeline for needing this makes me less inclined to choose the 15 day shipping option.
Thanks for mentioning the current draw; although I am current limiting the LEDs at about 10 mA each (total 200 mA), upon your suggestion I decided to change to a AAA, which I have tested with a load resistor and multimeter to verify it can meet the current demands. I will, however, need to add a dc-dc boost converter to the board, as I'd prefer to avoid requiring 2 AAAs due to size. Might as well add a transistor to the circuit, while I'm at it.
I'm happy to re-upload the files and await approval afterwards, if you'd like.

@maxwofford maxwofford left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swap out those files and I can approve the PR!

@roy-rishi

Copy link
Copy Markdown
Contributor Author

Just swapped them!

@maxwofford maxwofford left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just sent out the grant

@maxwofford
maxwofford merged commit 5cef921 into hackclub:main May 10, 2024
@roy-rishi

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Submission New Boards!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants