Make JA4s have names + drop unused index - #1453
Merged
Merged
Conversation
Contributor
Greptile SummaryThis PR adds JA4 names to the admin heartbeats response. The main changes are:
Confidence Score: 4/5The API response shape and schema updates are straightforward, with one rollback-path issue that should be corrected to avoid schema drift. The changed request specs and docs cover the intended JA4 response update, and the remaining concern is isolated to migration rollback behavior rather than normal forward execution. db/migrate/20260620232900_drop_unused_heartbeat_indexes.rb
What T-Rex did
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
db/migrate/20260620232900_drop_unused_heartbeat_indexes.rb:23-27
**Rollback adds index**
The `down` path recreates `index_heartbeats_on_last_language_user_id`, but the schema before this migration did not contain that index. Rolling this migration back would leave the database with a new partial index that was not part of the previous schema, which can cause schema drift and an unexpected large index build on `heartbeats` during rollback.
Reviews (1): Last reviewed commit: "Update Swagger specs" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
JA4s don't have names :(
Describe your changes
Make the admin heartbeats endpoint return JA4 fingerprints and names.
Screenshots / Media
N/A