Keep Docker dependency cache between jobs - #1508
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the production Docker build to make JavaScript dependencies portable across CI jobs by baking node_modules into the javascript-dependencies stage layer and consuming it via BuildKit bind mounts, instead of relying on a cache mount that Blacksmith wasn’t restoring.
Changes:
- Install JS dependencies directly into an immutable image layer in
javascript-dependencies(removing the/rails/.depscache-mount approach). - Keep Bun’s isolated linker and continue using Bun’s download cache mount.
- Switch docs and Vite asset stages to bind-mount
node_modulesfrom the dependencies stage; add dedicated cache mounts for Vite cache directories.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The failed main build spent 46.4s reinstalling packages. The next Blacksmith PR build reused the dependency layer and finished its Docker build in 4.7s.