TriggerPad#425
Merged
Merged
Conversation
new file: hackpads/TriggerPad/firmware/config.h new file: hackpads/TriggerPad/firmware/keyboard.json new file: hackpads/TriggerPad/firmware/keymaps/default/keymap.c new file: hackpads/TriggerPad/firmware/rules.mk new file: hackpads/TriggerPad/pcb/Screenshot 2025-02-11 190539.png new file: hackpads/TriggerPad/pcb/Screenshot 2025-02-11 190630.png new file: hackpads/TriggerPad/pcb/Screenshot 2025-02-11 190726.png new file: hackpads/TriggerPad/pcb/Screenshot 2025-02-14 140855.png new file: hackpads/TriggerPad/pcb/fp-info-cache new file: hackpads/TriggerPad/pcb/fp-lib-table new file: hackpads/TriggerPad/pcb/macro.kicad_pcb new file: hackpads/TriggerPad/pcb/macro.kicad_prl new file: hackpads/TriggerPad/pcb/macro.kicad_pro new file: hackpads/TriggerPad/pcb/macro.kicad_sch new file: hackpads/TriggerPad/pcb/macro.step new file: hackpads/TriggerPad/production/case/Case Top.stl new file: hackpads/TriggerPad/production/case/Case bottom.stl new file: hackpads/TriggerPad/production/gerber.zip new file: hackpads/TriggerPad/readme.md
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
Everything looks good! You're just missing your firmware in your production folder - once that is done I will be happy to approve this. |
new file: hackpads/TriggerPad/production/QMK/keyboard.json new file: hackpads/TriggerPad/production/QMK/keymaps/default/keymap.c new file: hackpads/TriggerPad/production/QMK/rules.mk
Contributor
Author
|
I have added the firmware in the production folder I don't know if you could see the commit changes just lmk if I have to close this one and make another one |
Collaborator
|
Looks good to me! I have marked this as approved - you will hear from us soon! |
qcoral
requested changes
Feb 18, 2025
Member
qcoral
left a comment
qcoral
left a comment
There was a problem hiding this comment.
almost LGTM - can you upload a step file instead of an STL?
Contributor
Author
|
Lemme check
…On Tue, Feb 18, 2025 at 8:14 AM Alex Ren ***@***.***> wrote:
***@***.**** requested changes on this pull request.
almost LGTM - can you upload a step file instead of an STL?
—
Reply to this email directly, view it on GitHub
<#425 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4DJEZFEZARKY5LEFRR4PIL2QNL5BAVCNFSM6AAAAABXFYYRGSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMRUGE3DIOJSGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
new file: hackpads/TriggerPad/production/case/Case Top V2.step deleted: hackpads/TriggerPad/production/case/Case Top.stl deleted: hackpads/TriggerPad/production/case/Case bottom.stl
Contributor
Author
|
Done |
qcoral
requested changes
Feb 20, 2025
Member
qcoral
left a comment
qcoral
left a comment
There was a problem hiding this comment.
so close! can you upload a STEP of the full assembly in the CAD folder?
deleted: hackpads/TriggerPad/CAD/TriggerPad.stl
Contributor
Author
|
OOPS MB I just uploaded it rn!! |
qcoral
reviewed
Feb 24, 2025
Contributor
Author
|
Awesome, thanks!
…On Mon, Feb 24, 2025 at 12:59 PM Alex Ren ***@***.***> wrote:
Merged #425 <#425> into main.
—
Reply to this email directly, view it on GitHub
<#425 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4DJEZEQAWZ6QMP2AQTMHMT2ROB3ZAVCNFSM6AAAAABXFYYRGSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGQZTOOBQGAZTQOA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
Check off the following to let the reviewers know you've done everything:
[Yup] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[Yup] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[Yup] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[Yup] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[Yup] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[Yup] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:
If you're unsure about the format, make sure to check out this example and follow the format there.
If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!