Skip to content

Include PM Team in membership check#8516

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
t-will-gillis:add-website-pms-8515
Feb 18, 2026
Merged

Include PM Team in membership check#8516
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
t-will-gillis:add-website-pms-8515

Conversation

@t-will-gillis
Copy link
Copy Markdown
Member

@t-will-gillis t-will-gillis commented Feb 18, 2026

Fixes #8515

What changes did you make?

  • Added website-pm to memberOfAdminOrMergeTeam in github-actions/trigger-issue/add-preliminary-update/preliminary-update-comment.js

Why did you make the changes (we will use this info to test)?

  • Website PMs should be automatically excluded from the complexity eligibility checks

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • no visual change

@github-actions
Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-add-website-pms-8515 gh-pages
git pull https://github.com/t-will-gillis/website.git add-website-pms-8515

@github-actions github-actions Bot added role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 18, 2026
@t-will-gillis
Copy link
Copy Markdown
Member Author

Merging immediately so that PM can continue

@t-will-gillis t-will-gillis merged commit a9bffe5 into hackforla:gh-pages Feb 18, 2026
10 checks passed
@t-will-gillis t-will-gillis deleted the add-website-pms-8515 branch February 18, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Bug fix: Exclude members of website-pm team from "complexity eligibility" checks

1 participant