Make banner a single static image and update styles#1008
Merged
onnilinnala merged 1 commit intoJul 1, 2025
Conversation
The banner used to be able to have multiple images along with buttons you could swipe through. Since the banner seemed to only ever include one image and no buttons, making it a static image allows to simplify the code by removing EventImage component and containedEventImage button variants, since they weren't used anywhere else.
joonarafael
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's still possible to add multiple banners in the app, but it only displays one now. It would still be possible to add swipeable views later, should be easier now that the code is simplified.