Add minio support#345
Closed
SISheogorath wants to merge 2 commits intohackmdio:masterfrom
SISheogorath:feature/minio
Closed
Add minio support#345SISheogorath wants to merge 2 commits intohackmdio:masterfrom SISheogorath:feature/minio
SISheogorath wants to merge 2 commits intohackmdio:masterfrom
SISheogorath:feature/minio
Conversation
Member
|
Wow Minio looks fantastic! |
|
Adding minio support is great. I am not sure, if adding the minio-client and another case is really needed, as one could extend the S3-related configs to allow more S3-compatible storage-backends. Minio can be used with the aws-sdk (see http://docs.minio.io/docs/how-to-use-aws-sdk-for-javascript-with-minio-server) |
Contributor
Author
|
I agree I recently found erasys@2a66c73 I'm not sure if minio will always stay in sync with s3. But if we use AWS-sdk for now, it would smaller our dep chain which sounds very useful. That was after building this little PR ^^ |
Contributor
Author
|
Updated the PR to use the AWS-SDK. I'll test it later. |
Merged
Contributor
Author
|
closed in favor of #506 |
JJediny
pushed a commit
to 18F/codimd-cloudgov-template
that referenced
this pull request
Dec 16, 2020
Backport of hackmdio#345 to 1.x Signed-off-by: Sandro Jäckel <sandro.jaeckel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referring to https://minio.io/
I came to this as we talked about the problem with own image uploads to a self-hosted storage but keep state away from the container.
I have to test it later. But looks good to me.