Skip to content

Add support for minio#506

Merged
SISheogorath merged 1 commit intohackmdio:masterfrom
erasys:minio
Jan 23, 2018
Merged

Add support for minio#506
SISheogorath merged 1 commit intohackmdio:masterfrom
erasys:minio

Conversation

@marcdeop
Copy link
Copy Markdown
Contributor

@marcdeop marcdeop commented Jul 7, 2017

I know of the existence of #345 but it hasn't been updated in a while and there have been some changes on master that make that pull request useless.

I tried using our minio instance as if it were and Amazon S3 endpoint ( adding a slight change to support a different endpoint than the defaults from Amazon) but the aws-sdk refused to work ( for some reason it still contacts Amazon to verify the credentials).

Thus, I ended up opting for adding full support for minio using https://github.com/minio/minio-js

I also noticed that there is an s3bucket config option which somehow I believe it belongs to the s3 section but I didn't dare to change that.

@SISheogorath
Copy link
Copy Markdown
Contributor

SISheogorath commented Aug 21, 2017

Did you verify it works? I guess when it comes from @erasys it's running in production?

If so, can you please squash the commit messages together using git rebase -i HEAD~3 and provide one commit message that covers everything? (This makes it easier for you and us to keep the git tree in sync and the git history stays clean and short)

Thanks~

@SISheogorath SISheogorath mentioned this pull request Aug 21, 2017
@marcdeop
Copy link
Copy Markdown
Contributor Author

Thanks for checking this. We are indeed using it in our day to day work flow. However, I just realized that there was a minor change that I had to apply to our local setup, I will get back to you on this tomorrow evening ( European time)

Comment thread lib/web/imageRouter.js Outdated
secure: config.minio.secure,
accessKey: config.minio.accessKey,
secretKey: config.minio.secretKey
});
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unneeded semicolon to fix the linter warning: https://travis-ci.org/hackmdio/hackmd/jobs/267696722#L486

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@SISheogorath
Copy link
Copy Markdown
Contributor

SISheogorath commented Oct 9, 2017

I was about to verify this setup and noticed that I have to think about how to set it up myself. Would it be possible to provide a little guide/documentation about how to setup minio with HackMD?

Something like what is Minio (very short), what do I need to do to set it up and what are example values for the config section.

I can probably figure it out, but not everyone is so familiar with these projects as you and me, so let's go for some docs 👍

Notice there is also an S3 guide in ./docs/guides/

@SISheogorath SISheogorath added docs Releated to new or missing documentation WIP Do not merge labels Oct 10, 2017
@SISheogorath SISheogorath added this to the Next release milestone Oct 10, 2017
@marcdeop
Copy link
Copy Markdown
Contributor Author

We are quite busy with some deadlines at work but I hope I will have time for this next week :-)

I will get back to you then.

@SISheogorath
Copy link
Copy Markdown
Contributor

Do you need help for the docs or can we make it land during the next week?

@SISheogorath SISheogorath modified the milestones: 1.0.0-CE Release, Next release Dec 22, 2017
@SISheogorath SISheogorath removed the WIP Do not merge label Jan 23, 2018
@SISheogorath
Copy link
Copy Markdown
Contributor

Thanks for your work! I provide the docs after merging this.

Lots of thanks for this feature! Minio will allow people to have way better self-hosted experiences.

@SISheogorath SISheogorath merged commit eec2318 into hackmdio:master Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Releated to new or missing documentation feature Wants to add a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants