Skip to content

Fix IROperator::is_const's handling of casts.#9243

Open
alexreinking wants to merge 1 commit into
mainfrom
alexreinking/fix-9242
Open

Fix IROperator::is_const's handling of casts.#9243
alexreinking wants to merge 1 commit into
mainfrom
alexreinking/fix-9242

Conversation

@alexreinking

Copy link
Copy Markdown
Member

The IROperator::is_const function didn't check can_represent before stripping a cast. That allowed it to confuse a 255 for a -1.

Fixes #9242

Checklist

  • Tests added or updated (not required for docs, CI config, or typo fixes)
  • Commits include AI attribution where applicable (see Code of Conduct)

@alexreinking
alexreinking requested a review from shoaibkamil July 26, 2026 04:57
@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.28%. Comparing base (bb9a42a) to head (7d55cea).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/IROperator.cpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9243      +/-   ##
==========================================
- Coverage   70.30%   70.28%   -0.02%     
==========================================
  Files         255      255              
  Lines       78904    78949      +45     
  Branches    18866    18889      +23     
==========================================
+ Hits        55470    55491      +21     
+ Misses      17849    17846       -3     
- Partials     5585     5612      +27     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure in solve fuzzer

1 participant