fix(ratewise): 幣別頁 CTA 深連結+v2 首次輸入取代種子(#631、#633) - #637
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
✅ SEO 審計通過!所有 2026 標準驗證項目都符合要求。
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e1be963aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2e1be96 to
90effef
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90effef269
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
90effef to
09a2090
Compare
|
✅ SEO 審計通過!所有 2026 標準驗證項目都符合要求。
|
- pair 頁 converterHref 由裸 / 改為 ?from&to 深連結,金額頁維持 ?amount&from&to(#631) - AnswerHero 收斂為單一帶參數 hero 卡:快速答案+深連結 CTA 同卡,砍除語意重複的「立即換算」行銷段 - 可見文字變動申報:移除「立即換算」標題與 ctaLead 行銷句(PM 授權內容策略修正,parity 差異已跑腳本列冊) - 補 CTA href 單元測試(雙方向)與 e2e 深連結落地 case(krw-twd 點 CTA 落地即 KRW→TWD) - 附本 PR 共用 changeset(patch,涵蓋 631/633 使用者可見修復) 測試:pnpm vitest run 全綠;e2e ratewise.spec(desktop/mobile)通過;build:ratewise 通過 Co-authored-by: Cursor <cursoragent@cursor.com>
- 回寫閘門開啟前的首顆數字鍵先 clear 再 input,取代未動過的預設種子(#633,計算機慣例) - 運算子、小數點與退格保留種子串接語意;實體與虛擬鍵共用同一 inputWithSeedReplace 路徑 - 紅線回歸調整:stale seed 改以運算子首鍵驗證、拒鍵不開閘改以小數點驗證,語意守護不變 - 補首鍵取代單元測試(實體+虛擬)與 e2e:鍵入 123456789 顯示 123,456,789 - changeset 拆分為 631/633 各一筆 patch,描述使用者可見影響 測試:pnpm vitest run 全綠;e2e converter-v2 desktop/mobile 通過;typecheck 與 build 通過 Co-authored-by: Cursor <cursoragent@cursor.com>
09a2090 to
a287765
Compare
|
✅ SEO 審計通過!所有 2026 標準驗證項目都符合要求。
|
Summary
/改為?from&to深連結(金額頁維持?amount&from&to),落地即正確幣別對;同時依 QA 淘汰候選 1 裁決,將「立即換算」段與快速答案收斂為單一帶參數 hero 卡。123456789顯示123,456,789,非1,000,123,456,789。運算子/小數點/退格保留種子串接語意。Closes #631
Closes #633
驗收對照
href="/ratewise/?from=KRW&to=TWD"(雙方向單元測試)+e2e 點擊落地 select 為 KRW→TWDratewise.spec.ts「幣別頁 CTA 深連結(#631)」desktop/mobile 通過CTA 文字變動申報(PM 授權內容策略修正,不硬守 parity)
verify-visible-text-parity.mjs(baseline=base 7bea6cc)差異僅以下兩節點,34 幣對頁+金額頁一致,無其他文字變動:CTA 按鈕文字「開始換算 {FROM} → {TO}」保留不變。
閘門結果
pnpm test:全綠(ratewise 177 檔 4,013 案例;converter-v2 全綠)pnpm typecheck/pnpm build:ratewise:通過(pre-push 亦驗)verify-ssg-invariance.mjsvs base build):diff 240 頁全數為幣別 pair/金額頁([bug] 幣別頁主 CTA 斷幣別脈絡:裸 /ratewise/ 落地變預設 TWD→JPY #631 預期變更),非幣別頁 diff = 0(v2 flag off 輸出不變)screenshots/cta-deeplink-pair-hero-*.png、cta-deeplink-landing-*.png、v2-first-input-replaces-seed-*.pngMade with Cursor