Skip to content

fix(ratewise): 平板 md–lg 帶閱讀寬度收斂與隱私頁寬版正文(#594 三階 A11/A12) - #663

Merged
s123104 merged 1 commit into
experiment/ratewise-product-2026h2from
fix/594-tablet-stage3
Jul 7, 2026
Merged

fix(ratewise): 平板 md–lg 帶閱讀寬度收斂與隱私頁寬版正文(#594 三階 A11/A12)#663
s123104 merged 1 commit into
experiment/ratewise-product-2026h2from
fix/594-tablet-stage3

Conversation

@s123104

@s123104 s123104 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Refs #594(第三階段殘項;epic 由 PM 統一收,不 close)

收斂 PR #643 兩條 review threads(PM 核實仍有效):

  • A11thread):CurrencyLandingPage 在 md–lg 帶(768–1023px,如 820px iPad 直向)吃 max-w-5xl 寬容器但無 lg: grid,行長過長。
  • A12thread):Privacy 有 220px 側欄 rail 但未放寬容器,lg 下正文僅約 492px。

修法(最小 diff)

ContentPageLayout 新增 width="wide-lg"max-w-3xl lg:max-w-5xl):僅 ≥lg 放寬容器,md–lg 帶維持閱讀寬度。幣別頁與隱私頁均改用此模式——一次解掉 A11(md–lg 收斂)與 A12(lg 正文放寬),且與 #643 既有 lg: 兩欄 grid 結構完全對齊,不動 DOM。

驗證數據(computed style)

頁面 視口 Before After
幣別頁 /usd-twd/ 820×1180(md–lg 帶) 容器 805px(max-w 1024 不設限) 容器 768px(閱讀寬度收斂)
幣別頁 /usd-twd/ 1024×768(lg) 容器 1009px+兩欄 grid 容器 1009px+兩欄 grid(零變化)
隱私頁 /privacy/ 1024×768(lg) 正文 492px 正文 733px
隱私頁 /privacy/ 1440×900 正文 492px 正文 748px
兩頁 390×844(手機) ImageMagick AE=0(像素級零變化)

前後截圖(20 張)存 screenshots/{before,after}-{currency,privacy}-{820x1180,768x1024,1024x768,1440x900,390x844}.png

SSG 非目標頁零 diff

dist 驗證:aboutfaq 維持 max-w-3xlguideopendata 維持 max-w-5xlwidth="wide" 語意不變),僅 privacy 與幣別/金額頁切至 max-w-3xl lg:max-w-5xl

Test plan

  • pnpm --filter @app/ratewise exec vitest run:184 檔 4842 測試全綠(含新增 wide-lg 單元測試)
  • pre-commit(lint-staged/typecheck/prettier/002 守門)與 pre-push(typecheck/test/build:ratewise)全過
  • changeset(patch)+ 002 一筆(+177)

Made with Cursor

- ContentPageLayout 新增 width="wide-lg"(max-w-3xl lg:max-w-5xl):僅 ≥lg 放寬容器,供 lg: 兩欄 grid 頁使用
- A11:CurrencyLandingPage 改用 wide-lg,820px iPad 直向等 md–lg 帶收斂為 768px 閱讀寬度
- A12:Privacy 改用 wide-lg,lg 下 220px 側欄旁正文由約 492px 放寬至約 748px,對齊 guide 頁側欄模式
- 手機視口 390×844 前後截圖 AE=0;dist 驗證非目標頁容器 class 零 diff
- 新增 ContentPageLayout wide-lg 單元測試;changeset patch 與 002 紀錄同批

測試:ratewise vitest 全綠(184 檔 4842 測試);四視口幣別頁與隱私頁前後截圖存 screenshots/

Refs #594

Co-authored-by: Cursor <cursoragent@cursor.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

✅ SEO 審計通過!所有 2026 標準驗證項目都符合要求。

  • ✅ Sitemap 2026 標準
  • ✅ Breadcrumb Schema
  • ✅ JSON-LD 結構化數據
  • ✅ 內部連結結構

@s123104
s123104 merged commit 0cc84a8 into experiment/ratewise-product-2026h2 Jul 7, 2026
11 checks passed
@s123104
s123104 deleted the fix/594-tablet-stage3 branch July 7, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant