Skip to content

fix(ratewise): 平板 ≥1024 兩欄佈局適配(#594 二階) - #643

Merged
s123104 merged 1 commit into
experiment/ratewise-product-2026h2from
fix/594-tablet-two-column
Jul 6, 2026
Merged

fix(ratewise): 平板 ≥1024 兩欄佈局適配(#594 二階)#643
s123104 merged 1 commit into
experiment/ratewise-product-2026h2from
fix/594-tablet-two-column

Conversation

@s123104

@s123104 s123104 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

摘要

Closes #594(二階:≥1024 兩欄佈局;一階 overlay max-width 已由 #596 落地)

lg: responsive class 為主的收斂,<1024px(手機/直向平板)視覺零變化(前後截圖像素 diff AE=0):

  • 首頁換算器(v1/v2 共用)rateWiseLayoutTokens.content 於 ≥1024px 轉 lg:grid-cols-[minmax(0,28rem)_minmax(0,1fr)] 兩欄——左欄換算核心(28rem,維持行動版設計比例)、右欄常用貨幣+全部幣種輔助資訊(原 md 起顯示於下方的區塊移入右欄);v2 等值雙列+rate chip+sparkline+keypad 常駐外層規格不動
  • 內容頁:隱私政策頁目錄 chips 於 ≥1024px 轉左側 220px sticky 錨點欄(與 guide 頁既有 rail 同款式),正文欄收斂閱讀寬度;此處為配合兩欄加了一層 wrapper div(DOM 結構有變、節點順序不變,手機視口 AE=0 已驗證)。guide 頁既有錨點側欄複驗正常,不重複改動。
  • 幣別 SEO 頁(34 幣對+金額頁):容器改 wide(max-w-5xl),六段 IA 寬版排列——Answer Hero 快速答案與 CTA 並排(lg:grid-cols-[minmax(0,1fr)_auto])、報價對比與後續半欄區塊成對、在地情境/管道比較/使用步驟/FAQ/相關攻略標 lg:col-span-2 全幅。
  • 金額頁半欄懸空修正(審查 Blocking 2):金額頁 grid 有第三個半欄子項(金額階梯表),奇數子項使常見金額互鏈(7 列高卡)右側整排懸空;互鏈於金額頁(ladderRows.length > 0)改標 lg:col-span-2 全幅,pair 頁維持與報價對比卡成對。
  • 韓系扁平原則:零新增漸層與陰影,僅用間距與既有 hairline 分層(design-system-guards 全綠)。

已知偏移申報(不在本 PR 修)

v1/multi 計算機 sheet(CalculatorKeyboard,viewport-fixed 置中)於 ≥1024 兩欄下開啟時,與左欄換算器有明顯水平偏移(sheet 錨定視窗中線、換算器在左欄):594-after-home-v1-calculator-open-1440x900.png。modal 模式功能不破;依 PM 指示留待 E3 殼層收斂線(BottomSheet primitive 消費)一併處理。

驗收證據(screenshots/,QA 暫存不入版控)

截圖矩陣腳本:scripts/qa/issue-594-screenshot-matrix.mjs(5 頁 × 5 視口 × before/after,console error 0)

頁面 Before After
首頁 v1 1440×900 594-before-home-v1-1440x900.png(單欄置中+大量留白) 594-after-home-v1-1440x900.png(兩欄)
首頁 v2 1024×768 594-before-home-v2-1024x768.png 594-after-home-v2-1024x768.png(keypad 常駐不動)
guide 1440×900 594-before-guide-1440x900.png(既有錨點欄) 594-after-guide-1440x900.png(零變化)
privacy 1440×900 594-before-privacy-1440x900.png(chips 置頂) 594-after-privacy-1440x900.png(sticky 錨點欄)
jpy-twd 1440×900 594-before-jpy-twd-1440x900.png(max-w-3xl 窄欄) 594-after-jpy-twd-1440x900.png(寬版+CTA 並排)
金額頁 jpy-twd/10000 1440×900 594-before-amount-jpy-twd-10000-1440x900.png(互鏈半欄懸空) 594-after-amount-jpy-twd-10000-1440x900.png(互鏈全幅)

手機零變化證明(ImageMagick compare -metric AE 前後逐像素):

  • guide/privacy/jpy-twd × {390×844, 375×667}:AE=0(逐像素一致)
  • home v1/v2 × 兩視口:AE 0.2%~0.4%,diff 圖確認差異僅在「資料來源刷新時間戳」與 live 走勢圖線條(時間性資料,非佈局);768×1024 直向平板五頁全部 AE=0

SSG 驗證(baseline=分支起點 bacd818 build):

  • verify-ssg-invariance.mjs:255 頁中非目標頁 13 頁(faq/about/guide/multi/settings/favorites/open-data/open-source/seo-tech/三篇 authority guide/offline)零 diff,變更零外溢;242 頁 diff 均為目標頁(首頁、privacy、34 幣對+金額頁)——首頁與幣別頁為 class 追加、privacy 另含目錄 wrapper div 結構調整(順序不變、手機 AE=0)
  • verify-visible-text-parity.mjs(krw-twd/usd-twd/jpy-twd/twd-krw/krw-twd/50000/jpy-twd/10000):6/6 PASS,可見文字節點集合等價

閘門

測試:vitest 全套 4062 綠、typecheck、build:ratewise、SSG 不變性比對、visible-text-parity 6/6、六頁 × 五視口前後截圖與像素 diff

Made with Cursor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb937d6022

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/ratewise/src/components/CurrencyLandingPage.tsx
- 首頁換算器(v1/v2)lg 起轉兩欄 grid:左欄換算核心 28rem、右欄收藏與幣種列表;v2 keypad 常駐規格不變
- 隱私政策頁目錄於 lg 轉左側 sticky 錨點欄,正文閱讀寬度收斂
- 幣別 SEO 頁改 wide 容器+六段 IA 寬版排列:快速答案與 CTA 並排、全幅段落標 lg:col-span-2
- 金額頁常見金額互鏈改全幅:金額頁 grid 有第三個半欄子項(階梯表),奇數導致互鏈右側懸空
- 手機與 <1024px 佈局零變化(純 lg: class;前後截圖像素 diff AE=0)
- 新增 issue 594 截圖矩陣 QA 腳本;SSG 非目標頁 13 頁零 diff、可見文字等價驗證通過
- 更新 002 獎懲記錄與 changeset(patch)

測試:vitest 全套 4062 passed、typecheck、build:ratewise、SSG 不變性、text-parity、六頁×五視口前後截圖

Co-authored-by: Cursor <cursoragent@cursor.com>
@s123104
s123104 force-pushed the fix/594-tablet-two-column branch from eb937d6 to c773c19 Compare July 6, 2026 06:16
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

✅ SEO 審計通過!所有 2026 標準驗證項目都符合要求。

  • ✅ Sitemap 2026 標準
  • ✅ Breadcrumb Schema
  • ✅ JSON-LD 結構化數據
  • ✅ 內部連結結構

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c773c19b72

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/ratewise/src/pages/Privacy.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant