seeed interface: fix fileno issue with windows#902
seeed interface: fix fileno issue with windows#902mergify[bot] merged 2 commits intohardbyte:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #902 +/- ##
==========================================
Coverage ? 68.37%
==========================================
Files ? 71
Lines ? 6992
Branches ? 0
==========================================
Hits ? 4781
Misses ? 2211
Partials ? 0 |
|
This has come up also with with slcan (#760). |
0285c31 to
83dea3f
Compare
|
Thanks for the feedback @bmeisels. I think that I understood what you're asking for based on those two PRs you linked to, so I went ahead and amended the commit. |
83dea3f to
16a3a10
Compare
| except io.UnsupportedOperation: | ||
| raise NotImplementedError("fileno is not implemented using current CAN bus") | ||
|
|
||
| return -1 |
There was a problem hiding this comment.
This line now looks unreachable, and should be removed.
There was a problem hiding this comment.
@hardbyte I've amended the commit to remote that line 👍
816bdd9 to
f1f7fe3
Compare
f1f7fe3 to
77c1737
Compare
hardbyte
left a comment
There was a problem hiding this comment.
Thanks!
Sorry it took me a long time to get back to this
|
Is there anything I can do to help get this merged into develop? |
Environment:
Issue
When using the seeedstudio interface on Linux or MacOS, I'm able to connect to the interface and send/receive messages.
When running the same script on Windows 10 the following error is thrown:
From the python-serial docs,
fileno()is only supported on Posix platforms.The commit below fixes the issue for me, without breaking functionality on Linux, although I'm not sure if this is correct solution.