Skip to content

amico vault/device/note (#113): B3 — migrate the remaining bookkeeping verbs - #125

Closed
aarontrowbridge wants to merge 1 commit into
b2-catalog-verbfrom
b3-bookkeeping-verbs
Closed

amico vault/device/note (#113): B3 — migrate the remaining bookkeeping verbs#125
aarontrowbridge wants to merge 1 commit into
b2-catalog-verbfrom
b3-bookkeeping-verbs

Conversation

@aarontrowbridge

Copy link
Copy Markdown
Member

What this is

Slice B3 of the amico CLI spine (spec-20260708-112732 §3.1, §7.3): replace the three remaining B1 stub verbs (vault, device, note) with real bodies, on the exact B2 pattern — a pure core + a *_verb.ts body + tests, wired into verbs.ts / amico.ts.

Stacked: base is b2-catalog-verb (#119, which stacks on #118). Review/merge B2 first. Closes #113.

The three verbs

amico vault query — knowledge-graph retrieval (read-only)

Ranks insights/ + experiments/ notes by relevance to a --q query (title > tags > body weighting), with --type / --platform / --kind / --limit filters. Retrieval, not front-loading context. Pure core: vault_query.ts (never-throwing note loader + minimal regex frontmatter parse + ranker).

amico device status | next | lock — the dispatcher successor (§3.1 / W-2)

The 87-line dispatcher agent is retired — its job is pure lookup with no LLM judgment, so it becomes a deterministic verb. Pure core device_graph.ts is ported from the local/device-management branch's already-tested, vscode-free calibration-graph logic (loadGraph/evaluate/nextActions/registry), stripped of the server/queue transport.

  • statusDeviceStatus projection (per-qubit worst-status rollup, measured-only metrics, ranked node verdicts). Honesty rule: a node with no result is uncharacterized, one past its TTL is stale, a fresh node under a moved dependency is suspect — never a fabricated number. No graph on disk → overall: uncharacterized.
  • next — ranked next-actions (roots-first via the pure evaluate()). qilc (premium) nodes surface the Intonatissimo funnel (product name + "closed-loop calibration" capability + invite, never the method acronym in user-facing copy) and a standard fallback node.
  • lock — the benchmark-exclusivity lock (W-2): a device under a benchmark allocation accepts_submission: false and suspends_fanout: true. A concurrent acquire by another owner is refused (exit 64); same-owner re-acquire is idempotent (keeps acquired_at); release frees it. device next/status on a locked device report idle: false / accepts_submission: false.

--now <iso> pins the evaluation clock so age/staleness are deterministic in tests and replay.

amico note write | bump-best — librarian bookkeeping (§3.1 / W-3), deterministic

The librarian's deterministic half migrates to the CLI (insight extraction stays a headless leaf).

  • write — a fully-templated experiment note (frontmatter + body skeleton) into experiments/. --from-run <dir> reads result.toml for fidelity/duration; --date pins the id.
  • bump-best — surgical edit of a system-context note's best_gates list: replace the incumbent gate entry only on strictly-higher fidelity (else no-op, exit 0), add if absent, leaving the rest of the note byte-identical.

Pure cores: note.ts (renderExperimentNote / mergeBestGates / bumpBestGatesInText).

S31

Flag names sidestep the banned physics-knob double-dash flags (gate/pulse/system): the gate discriminator is --kind (as B2 established). test/s31.test.ts stays green. Env overrides $AMICO_VAULT_DIR / $AMICO_DEVICE_DIR mirror B2's $AMICO_CATALOG_DIR for testability.

Tests

pnpm --filter @amicode/amico-run test191 passed (was 141; +50 across vault_verb / device_verb / note_verb). amico.test.ts's "still B1 stubs" block is replaced with real-routing assertions. typecheck + build clean.

Follow-up (out of scope here)

  • device status intentionally drops the drive-lines-online rollup and main_config merge — those need a live job-server health() call (a network transport), which S31 keeps out of the CLI core; they belong with the queue-client seam.
  • mcp-serve remains the one stub seam (verb↔tool --list mapping works; the MCP stdio transport lands later, SDK-free per S31).
  • note bump-best parses the best_gates inline-table list form specifically; a general YAML frontmatter rewriter is a larger, separate concern.

Note: fork CI may be RED due to the known private-fork vendored-binary token issue, not this change.

🤖 Generated with Claude Code

… verbs

Replaces the three remaining B1 stub verbs with real bodies, following the B2
pattern (pure core + `*_verb.ts` body + tests, wired into verbs.ts/amico.ts):

- `amico vault query` — read-only knowledge-graph retrieval. Ranks
  insights/experiments by relevance (title > tags > body) to a `--q` query,
  with `--type/--platform/--kind/--limit` filters. Pure core: vault_query.ts.

- `amico device status|next|lock` — the dispatcher successor (§3.1 / W-2). Pure
  evaluate()/nextActions() over an acyclic calibration graph (ported from the
  device-management branch, stripped of vscode/server coupling):
  * status  — DeviceStatus projection; honesty rule (uncharacterized/stale by
    TTL, suspect on a moved dependency) — never a fabricated number.
  * next    — ranked actions, roots-first; qilc nodes surface the Intonatissimo
    premium funnel (product + capability, never the method acronym) + standard
    fallback.
  * lock    — benchmark-exclusivity: a device under a benchmark allocation
    accepts no concurrent submission and suspends leaf fan-out; a concurrent
    acquire by another owner is refused, same-owner re-acquire is idempotent.
  `--now <iso>` pins the evaluation clock for deterministic replay. Pure core:
  device_graph.ts.

- `amico note write|bump-best` — the librarian's deterministic bookkeeping half
  (§3.1 / W-3): write a fully-templated experiment note; bump a system-context
  note's best_gates only on strictly-higher fidelity (surgical frontmatter edit,
  rest of the note untouched). Pure core: note.ts.

The dispatcher agent is retired: its lookup becomes the pure `device` verb.
All four spine verbs now have real bodies; only mcp-serve remains a seam.

S31: flag names sidestep the banned physics-knob double-dash flags
(gate/pulse/system) — the gate discriminator is `--kind` as in B2; test/s31.test.ts
stays green. Env overrides ($AMICO_VAULT_DIR, $AMICO_DEVICE_DIR) mirror B2's
$AMICO_CATALOG_DIR for testability.

Tests: +50 (vault_verb/device_verb/note_verb), amico.test.ts stub-block replaced
with real-routing assertions. Full amico-run suite 191 passed (was 141).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@jack-champagne

Copy link
Copy Markdown
Member

Closing — already delivered, same as #119.

b3-bookkeeping-verbs tip 70eea56 is a direct ancestor of main (d03d3c8) and git diff main...b3-bookkeeping-verbs is empty.

Base was b2-catalog-verb (see #119), also fully in main.

Branch preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants