amico vault/device/note (#113): B3 — migrate the remaining bookkeeping verbs - #125
Closed
aarontrowbridge wants to merge 1 commit into
Closed
amico vault/device/note (#113): B3 — migrate the remaining bookkeeping verbs#125aarontrowbridge wants to merge 1 commit into
aarontrowbridge wants to merge 1 commit into
Conversation
… verbs
Replaces the three remaining B1 stub verbs with real bodies, following the B2
pattern (pure core + `*_verb.ts` body + tests, wired into verbs.ts/amico.ts):
- `amico vault query` — read-only knowledge-graph retrieval. Ranks
insights/experiments by relevance (title > tags > body) to a `--q` query,
with `--type/--platform/--kind/--limit` filters. Pure core: vault_query.ts.
- `amico device status|next|lock` — the dispatcher successor (§3.1 / W-2). Pure
evaluate()/nextActions() over an acyclic calibration graph (ported from the
device-management branch, stripped of vscode/server coupling):
* status — DeviceStatus projection; honesty rule (uncharacterized/stale by
TTL, suspect on a moved dependency) — never a fabricated number.
* next — ranked actions, roots-first; qilc nodes surface the Intonatissimo
premium funnel (product + capability, never the method acronym) + standard
fallback.
* lock — benchmark-exclusivity: a device under a benchmark allocation
accepts no concurrent submission and suspends leaf fan-out; a concurrent
acquire by another owner is refused, same-owner re-acquire is idempotent.
`--now <iso>` pins the evaluation clock for deterministic replay. Pure core:
device_graph.ts.
- `amico note write|bump-best` — the librarian's deterministic bookkeeping half
(§3.1 / W-3): write a fully-templated experiment note; bump a system-context
note's best_gates only on strictly-higher fidelity (surgical frontmatter edit,
rest of the note untouched). Pure core: note.ts.
The dispatcher agent is retired: its lookup becomes the pure `device` verb.
All four spine verbs now have real bodies; only mcp-serve remains a seam.
S31: flag names sidestep the banned physics-knob double-dash flags
(gate/pulse/system) — the gate discriminator is `--kind` as in B2; test/s31.test.ts
stays green. Env overrides ($AMICO_VAULT_DIR, $AMICO_DEVICE_DIR) mirror B2's
$AMICO_CATALOG_DIR for testability.
Tests: +50 (vault_verb/device_verb/note_verb), amico.test.ts stub-block replaced
with real-routing assertions. Full amico-run suite 191 passed (was 141).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 9, 2026
Member
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
Slice B3 of the
amicoCLI spine (spec-20260708-112732 §3.1, §7.3): replace the three remaining B1 stub verbs (vault,device,note) with real bodies, on the exact B2 pattern — a pure core + a*_verb.tsbody + tests, wired intoverbs.ts/amico.ts.Stacked: base is
b2-catalog-verb(#119, which stacks on #118). Review/merge B2 first.Closes #113.The three verbs
amico vault query— knowledge-graph retrieval (read-only)Ranks
insights/+experiments/notes by relevance to a--qquery (title > tags > body weighting), with--type/--platform/--kind/--limitfilters. Retrieval, not front-loading context. Pure core:vault_query.ts(never-throwing note loader + minimal regex frontmatter parse + ranker).amico device status | next | lock— the dispatcher successor (§3.1 / W-2)The 87-line dispatcher agent is retired — its job is pure lookup with no LLM judgment, so it becomes a deterministic verb. Pure core
device_graph.tsis ported from thelocal/device-managementbranch's already-tested, vscode-free calibration-graph logic (loadGraph/evaluate/nextActions/registry), stripped of the server/queue transport.status—DeviceStatusprojection (per-qubit worst-status rollup, measured-only metrics, ranked node verdicts). Honesty rule: a node with no result isuncharacterized, one past its TTL isstale, a fresh node under a moved dependency issuspect— never a fabricated number. No graph on disk →overall: uncharacterized.next— ranked next-actions (roots-first via the pureevaluate()).qilc(premium) nodes surface the Intonatissimo funnel (product name + "closed-loop calibration" capability + invite, never the method acronym in user-facing copy) and a standard fallback node.lock— the benchmark-exclusivity lock (W-2): a device under abenchmarkallocationaccepts_submission: falseandsuspends_fanout: true. A concurrent acquire by another owner is refused (exit 64); same-owner re-acquire is idempotent (keepsacquired_at); release frees it.device next/statuson a locked device reportidle: false/accepts_submission: false.--now <iso>pins the evaluation clock so age/staleness are deterministic in tests and replay.amico note write | bump-best— librarian bookkeeping (§3.1 / W-3), deterministicThe librarian's deterministic half migrates to the CLI (insight extraction stays a headless leaf).
write— a fully-templated experiment note (frontmatter + body skeleton) intoexperiments/.--from-run <dir>readsresult.tomlfor fidelity/duration;--datepins the id.bump-best— surgical edit of a system-context note'sbest_gateslist: replace the incumbent gate entry only on strictly-higher fidelity (else no-op, exit 0), add if absent, leaving the rest of the note byte-identical.Pure cores:
note.ts(renderExperimentNote/mergeBestGates/bumpBestGatesInText).S31
Flag names sidestep the banned physics-knob double-dash flags (gate/pulse/system): the gate discriminator is
--kind(as B2 established).test/s31.test.tsstays green. Env overrides$AMICO_VAULT_DIR/$AMICO_DEVICE_DIRmirror B2's$AMICO_CATALOG_DIRfor testability.Tests
pnpm --filter @amicode/amico-run test→ 191 passed (was 141; +50 acrossvault_verb/device_verb/note_verb).amico.test.ts's "still B1 stubs" block is replaced with real-routing assertions.typecheck+buildclean.Follow-up (out of scope here)
device statusintentionally drops the drive-lines-online rollup andmain_configmerge — those need a live job-serverhealth()call (a network transport), which S31 keeps out of the CLI core; they belong with the queue-client seam.mcp-serveremains the one stub seam (verb↔tool--listmapping works; the MCP stdio transport lands later, SDK-free per S31).note bump-bestparses thebest_gatesinline-table list form specifically; a general YAML frontmatter rewriter is a larger, separate concern.🤖 Generated with Claude Code