amico vault/note: mount-aware status/resolve, union query, routed note route - #131
Closed
aarontrowbridge wants to merge 3 commits into
Closed
amico vault/note: mount-aware status/resolve, union query, routed note route#131aarontrowbridge wants to merge 3 commits into
aarontrowbridge wants to merge 3 commits into
Conversation
…ecedence (vault-cli spec canonical order) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…a stack Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…_intent fallback Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Closing — already delivered.
Base was Note this means #132, which stacked on this branch, has only 8 lines left that aren't in main — retargeting it to main rather than closing it. cc @aaron — branch preserved. |
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stacked on #125 (B3) — base branch is
b3-bookkeeping-verbs; merge after it.Closes the single-vault gap in the B3 spine verbs:
vault_query.ts'svaultDir()was hardcoded to armonissima, and no verb knew the Armonia mount stack existed. Per depth-1 spec §7.3 (retrieval tools) + W-3 (routed librarian writes) and the approved vault-CLI spec's canonical mount semantics:src/mounts.ts(new) — the mount-stack resolver: markers +mounts.tomlorder/kind/writable overrides, canonical kind precedence (restricted 3 < team 4), rescue rule, discovery-order unlisted append. Twin of the extension'ssubstrate/mount_store.ts(PR Bootstrap parity: full Armonia mount-stack at session start (discovery, grants, splice, typed memory) #130) — headers cross-reference; unify-later follow-up named. Env seam for the bundle-exec test boundary:$AMICO_VAULTS_ROOT/$AMICO_MOUNTS_TOML($AMICO_VAULT_DIRstill wins, forcing the single-mount back-compat path).vault status --json— field-compatible with the bashamico-vault status --json({ok, mounts:[{id,path,kind,writable,last_sync,warnings}], error}, drift warnings with manifest-wins,git log -1 --format=%cr). Note: matches the bash envelope exactly, so no top-levelverb/subcommand— unlike the other amico verbs, by design.vault resolve <relpath>— first-hit across read precedence.vault query— union over all mounts in precedence order with mount provenance on every hit; same-relpath collision → higher-precedence mount wins;--mount <id>restricts.note route(new subcommand) — routed generic note writes by intent: first writable mount of the intent kind, else personal +route_intent: <kind>frontmatter stamp (never silently drop, never write a ro mount).--type experimentis rejected with a pointer tonote write(schema-complete experiment notes staynote write's job). B3'snote write/bump-bestare byte-for-byte untouched.Verified against the real machine
vault statusreproduces this machine's session-start hook mount stack exactly (personal → restricted → team, manifest order);vault resolve STRATEGY.mdfirst-hits armonissima;vault queryreturns cross-mount hits with provenance.Testing
pnpm test: 229 passed (baseline 191 — +38 new, zero regressions; all pre-existing B3 suites additions-only).pnpm typecheckclean. New:mounts.test.tsfixture matrix (a)–(i), status/resolve/union-query verb tests,note routepure + bundle tests.CI: expected red on the pre-existing private-fork binary token issue — unrelated.
🤖 Generated with Claude Code