Skip to content

feat: add service locator API initial draft#230

Merged
nathanklick merged 11 commits intomainfrom
00190-Service-Locator
Aug 3, 2023
Merged

feat: add service locator API initial draft#230
nathanklick merged 11 commits intomainfrom
00190-Service-Locator

Conversation

@nathanklick
Copy link
Copy Markdown
Member

@nathanklick nathanklick commented Aug 3, 2023 •
edited
Loading

Description

This pull request changes the following:

  • Adds the new Service Locator API
  • Adds some initial unit test coverage (needs further improvement)
  • Adds additional functionality to the Resource Loader API
  • Enable publishing of the Service Loader API to Maven Central
  • Adds Base API reflection & collection utility classes

Related Issues

@nathanklick
feat: adds a basic ServiceLocator base class
f7b661c 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: minor refactors and added unit tests
6c452cc 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: refactor reflection
8c977e7 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: update and refactor locator/supplier
17ff7ce 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: adds existence check methods to the reflection helpers & build…
becd213 
…s out more of the locator API

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: finalize service locator interface
15c554e 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: save state before refactor
a8a1cf1 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: save work in progress
b08cd33 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: refactor service locator to utilize the java service loader
b9592fa 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: refactored the locator and partial implementation of the artif…
eff8ee7 
…act loader

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: finalize artifact loader
33ba0cc 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick nathanklick self-assigned this Aug 3, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 3, 2023

Unit Test Results

13 files  +  4  13 suites  +4   29s ⏱️ -1s
57 tests +19  54 ✔️ +19  3 💤 ±0  0 ❌ ±0 
58 runs  +20  55 ✔️ +20  3 💤 ±0  0 ❌ ±0 

Results for commit 33ba0cc. ± Comparison against base commit 3e665f3.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 3, 2023

Codecov Report

Merging #230 (33ba0cc) into main (3e665f3) will decrease coverage by 2.03%.
The diff coverage is 50.15%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #230      +/-   ##
============================================
- Coverage     56.70%   54.68%   -2.03%     
- Complexity      144      219      +75     
============================================
  Files            36       47      +11     
  Lines           723     1046     +323     
  Branches         73      129      +56     
============================================
+ Hits            410      572     +162     
- Misses          281      424     +143     
- Partials         32       50      +18
Files Changed Coverage Δ
...om/hedera/fullstack/base/api/collections/Pair.java 0.00% <0.00%> (ø)
...ra/fullstack/base/api/resource/ResourceLoader.java 0.00% <0.00%> (ø)
.../service/locator/api/ArtifactLoadingException.java 0.00% <0.00%> (ø)
...ra/fullstack/base/api/reflect/ReflectionUtils.java 36.61% <36.61%> (ø)
...k/base/api/reflect/ClassConstructionException.java 50.00% <50.00%> (ø)
...lstack/service/locator/api/MutableClassLoader.java 50.00% <50.00%> (ø)
...a/fullstack/base/api/collections/KeyValuePair.java 55.55% <55.55%> (ø)
.../fullstack/service/locator/api/ArtifactLoader.java 57.29% <57.29%> (ø)
...edera/fullstack/base/api/reflect/Construction.java 72.88% <72.88%> (ø)
...fullstack/service/locator/api/WrappedIterator.java 77.77% <77.77%> (ø)
... and 2 more

Impacted file tree graph

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 3, 2023 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

52.9% 52.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@nathanklick nathanklick marked this pull request as ready for review August 3, 2023 15:11
@nathanklick nathanklick mentioned this pull request Aug 3, 2023
Closed
@nathanklick nathanklick merged commit 1e81f65 into main Aug 3, 2023
@nathanklick nathanklick deleted the 00190-Service-Locator branch August 3, 2023 15:39
@nathanklick nathanklick mentioned this pull request Aug 3, 2023
Open
swirlds-automation added a commit that referenced this pull request Aug 4, 2023
@swirlds-automation
chore(release): 0.5.0 [skip ci]
c54e376 
## [0.5.0](v0.4.0...v0.5.0) (2023-08-04)

### Features

* add CI pipeline tests for network node helm installation ([#228](#228)) ([3e665f3](3e665f3))
* add service locator API initial draft ([#230](#230)) ([1e81f65](1e81f65))
* for the hedera-network Helm chart set the minimum Kubernetes server version ([#231](#231)) ([de9aceb](de9aceb))

### Bug Fixes

*  use reasonable defaults for the per node configuration in the values.yaml file ([#229](#229)) ([92032f9](92032f9))
* resolves the issues caused by the environment variable not being passed to the service scripts ([#235](#235)) ([022b03d](022b03d))
@swirlds-automation
Copy link
Copy Markdown
Contributor

swirlds-automation commented Aug 4, 2023

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jeromy-cannon jeromy-cannon mentioned this pull request Aug 7, 2023
Merged
@swirlds-automation
Copy link
Copy Markdown
Contributor

swirlds-automation commented Aug 8, 2023

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leninmehedy leninmehedy leninmehedy approved these changes

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@deepak-swirlds deepak-swirlds Awaiting requested review from deepak-swirlds

Assignees

@nathanklick nathanklick

Labels

released on @0.5.x released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SL: Enable module publishing to Maven Central SL: Initial API Design & Implementation

4 participants

@nathanklick @swirlds-automation @leninmehedy @jeromy-cannon