fix: correct KeyValuePair equals and add coverage for ServiceLocator by jeromy-cannon · Pull Request #257 · hashgraph/full-stack-testing

jeromy-cannon · 2023-08-07T15:04:19Z

Description

This pull request changes the following:

add coverage for ServiceLocator changes in PR feat: add service locator API initial draft #230
fix for KeyValuePair equals method not comparing value
bump JCovalent version for missing module exports

Related Issues

Closes SL: Add additional unit test coverage #232
Depends on feat: add module export for assertj and extensions jcovalent/jcovalent-junit-logging#12 and new tag 0.3.0 for JCovalent library

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

…/test/reflect/ReflectionUtilsTest.java Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

github-actions · 2023-08-07T17:01:31Z

Unit Test Results

16 files +  3 16 suites +3 33s ⏱️ +2s
85 tests +28 82 ✔️ +28 3 💤 ±0 0 ❌ ±0
86 runs +28 83 ✔️ +28 3 💤 ±0 0 ❌ ±0

Results for commit 943607d. ± Comparison against base commit 7f051c0.

This pull request removes 1 and adds 29 tests. Note that renamed tests count towards both.

com.hedera.fullstack.service.locator.test.api.ArtifactLoaderTest ‑ Logback: Artifacts dynamically loaded

com.hedera.fullstack.base.api.test.collections.KeyValuePairTest ‑ Test KeyValuePair
com.hedera.fullstack.base.api.test.reflect.ReflectionUtilsTest ‑ Validate primitive for Boolean.class
com.hedera.fullstack.base.api.test.reflect.ReflectionUtilsTest ‑ Validate primitive for Byte.class
com.hedera.fullstack.base.api.test.reflect.ReflectionUtilsTest ‑ Validate primitive for Character.class
com.hedera.fullstack.base.api.test.reflect.ReflectionUtilsTest ‑ Validate primitive for Double.class
com.hedera.fullstack.base.api.test.reflect.ReflectionUtilsTest ‑ Validate primitive for Float.class
com.hedera.fullstack.base.api.test.reflect.ReflectionUtilsTest ‑ Validate primitive for Integer.class
com.hedera.fullstack.base.api.test.reflect.ReflectionUtilsTest ‑ Validate primitive for Long.class
com.hedera.fullstack.base.api.test.reflect.ReflectionUtilsTest ‑ Validate primitive for Short.class
com.hedera.fullstack.base.api.test.reflect.ReflectionUtilsTest ‑ Validate primitive for String.class
…

♻️ This comment has been updated with latest results.

codecov · 2023-08-07T17:39:55Z

Codecov Report

Merging #257 (943607d) into main (7f051c0) will increase coverage by 7.55%.
The diff coverage is 50.00%.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #257      +/-   ##
============================================
+ Coverage     54.68%   62.23%   +7.55%     
- Complexity      219      254      +35     
============================================
  Files            47       47              
  Lines          1046     1046              
  Branches        129      130       +1     
============================================
+ Hits            572      651      +79     
+ Misses          424      344      -80     
- Partials         50       51       +1

Files Changed	Coverage Δ
...a/fullstack/base/api/collections/KeyValuePair.java	`66.66% <0.00%> (+11.11%)`	⬆️
.../fullstack/service/locator/api/ArtifactLoader.java	`70.83% <100.00%> (+13.54%)`	⬆️

... and 2 files with indirect coverage changes

nathanklick

The ReflectionUtilsTest class looks much cleaner and is now DRY.

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

sonarqubecloud · 2023-08-07T18:06:20Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

66.7% Coverage
0.0% Duplication

## [0.5.1](v0.5.0...v0.5.1) (2023-08-08) ### Bug Fixes * correct KeyValuePair equals and add coverage for ServiceLocator ([#257](#257)) ([5b17978](5b17978)) * enable overriding individual properties for sidecars ([#250](#250)) ([7d5a4e1](7d5a4e1)) * only allow jrs profile during node setup ([#249](#249)) ([dd326c1](dd326c1)) * typo in the semantic release config preventing the updates to Chart.yaml from being committed ([#252](#252)) ([02a576b](02a576b)) * update verification script so that CI pipeline fails if node fails to start ([#254](#254)) ([7f051c0](7f051c0))

swirlds-automation · 2023-08-08T23:54:20Z

🎉 This PR is included in version 0.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [0.6.0](v0.5.0...v0.6.0) (2023-08-09) ### Features * convert chart tests from the custom bash script to be BATS unit tests ([#256](#256)) ([0bcdfcb](0bcdfcb)) * update partial templates to match naming conventions and prefix with fullstack namespace ([#265](#265)) ([fb73b5d](fb73b5d)) ### Bug Fixes * correct KeyValuePair equals and add coverage for ServiceLocator ([#257](#257)) ([5b17978](5b17978)) * default tag is not set properly for proxy containers ([#266](#266)) ([deabd16](deabd16)) * enable overriding individual properties for sidecars ([#250](#250)) ([7d5a4e1](7d5a4e1)) * only allow jrs profile during node setup ([#249](#249)) ([dd326c1](dd326c1)) * typo in the semantic release config preventing the updates to Chart.yaml from being committed ([#252](#252)) ([02a576b](02a576b)) * update verification script so that CI pipeline fails if node fails to start ([#254](#254)) ([7f051c0](7f051c0))

swirlds-automation · 2023-08-09T00:47:50Z

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

nathanklick and others added 14 commits August 3, 2023 10:47

chore: added unit test coverage

61aa368

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>

@DisplayName("CtorService: Locator's iterator removes entry")

2526362

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

testWrapperAsPrimitiveClass

74a4e4a

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

testWrapperAsPrimitiveClass (default)

1588bea

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

testPrimitiveAsWrapperClass

a95b368

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

testLoad

bed415d

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

testLoadIOException

26aadf4

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

test load directory with no modules

aaf2d8f

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

logbackDynamicServiceRecursiveFolderLoading

199355b

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

logbackDynamicServiceLoadingWithNoPaths

39704b9

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

spotlessApply

be45381

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

call with empty parent to get more coverage

284c295

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

coverage for a jar with no manifest and no module descriptor

65ce21c

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

test key value pair equals and hash code, fix equals comparison

94d2bc6

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

jeromy-cannon self-assigned this Aug 7, 2023

Merge branch 'main' into 00232-SL-Add-Coverage

3b99a6b

nathanklick reviewed Aug 7, 2023

View reviewed changes

jeromy-cannon and others added 12 commits August 7, 2023 11:39

Update fullstack-base-api/src/test/java/com/hedera/fullstack/base/api…

f187743

…/test/reflect/ReflectionUtilsTest.java Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Update fullstack-base-api/src/test/java/com/hedera/fullstack/base/api…

3c62ada

…/test/reflect/ReflectionUtilsTest.java Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Update fullstack-base-api/src/test/java/com/hedera/fullstack/base/api…

1b73fc0

…/test/reflect/ReflectionUtilsTest.java Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Update fullstack-base-api/src/test/java/com/hedera/fullstack/base/api…

cb9921f

…/test/reflect/ReflectionUtilsTest.java Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Update fullstack-base-api/src/test/java/com/hedera/fullstack/base/api…

4c2d0d7

…/test/reflect/ReflectionUtilsTest.java Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Update fullstack-base-api/src/test/java/com/hedera/fullstack/base/api…

026cac8

…/test/reflect/ReflectionUtilsTest.java Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Update fullstack-base-api/src/test/java/com/hedera/fullstack/base/api…

09b3808

…/test/reflect/ReflectionUtilsTest.java Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Update fullstack-base-api/src/test/java/com/hedera/fullstack/base/api…

1aa284b

…/test/reflect/ReflectionUtilsTest.java Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Update fullstack-base-api/src/test/java/com/hedera/fullstack/base/api…

00fb85a

…/test/reflect/ReflectionUtilsTest.java Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Update fullstack-base-api/src/test/java/com/hedera/fullstack/base/api…

7f607a3

…/test/reflect/ReflectionUtilsTest.java Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

updated based on PR feedback

6573c11

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Merge branch 'main' into 00232-SL-Add-Coverage

a5fef76

nathanklick approved these changes Aug 7, 2023

View reviewed changes

nathanklick reviewed Aug 7, 2023

View reviewed changes

Comment thread fullstack-service-locator/build.gradle.kts Outdated

removed testImplementation(gav("com.jcovalent.junit.logging"))

ecf9bb0

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

nathanklick reviewed Aug 7, 2023

View reviewed changes

Comment thread fullstack-service-locator/build.gradle.kts Outdated

Update fullstack-service-locator/build.gradle.kts

943607d

Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

jeromy-cannon marked this pull request as ready for review August 7, 2023 17:54

jeromy-cannon merged commit 5b17978 into main Aug 7, 2023

jeromy-cannon deleted the 00232-SL-Add-Coverage branch August 7, 2023 18:08

swirlds-automation added the released on @0.5.x label Aug 8, 2023

swirlds-automation added the released label Aug 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: correct KeyValuePair equals and add coverage for ServiceLocator#257

fix: correct KeyValuePair equals and add coverage for ServiceLocator#257
jeromy-cannon merged 29 commits intomainfrom
00232-SL-Add-Coverage

jeromy-cannon commented Aug 7, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 7, 2023 •

edited

Loading

Uh oh!

codecov Bot commented Aug 7, 2023 •

edited

Loading

Uh oh!

nathanklick left a comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Aug 7, 2023

Uh oh!

swirlds-automation commented Aug 8, 2023

Uh oh!

swirlds-automation commented Aug 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jeromy-cannon commented Aug 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

codecov Bot commented Aug 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nathanklick left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Aug 7, 2023

Uh oh!

swirlds-automation commented Aug 8, 2023

Uh oh!

swirlds-automation commented Aug 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jeromy-cannon commented Aug 7, 2023 •

edited

Loading

github-actions Bot commented Aug 7, 2023 •

edited

Loading

codecov Bot commented Aug 7, 2023 •

edited

Loading