Skip to content

feat: update partial templates to match naming conventions and prefix with fullstack namespace#265

Merged
jeromy-cannon merged 12 commits intomainfrom
00210-partial-tmplt-namespace-prefix
Aug 8, 2023
Merged

feat: update partial templates to match naming conventions and prefix with fullstack namespace#265
jeromy-cannon merged 12 commits intomainfrom
00210-partial-tmplt-namespace-prefix

Conversation

@jeromy-cannon
Copy link
Copy Markdown
Contributor

Description

This pull request changes the following:

  • update partial templates to match naming conventions (camelCase)
  • prefix partial template names with fullstack namespace fullstack.*

Related Issues

…eUploader

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
…oader

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
…rivileged

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon self-assigned this Aug 8, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 8, 2023

Unit Test Results

16 files  ±0  16 suites  ±0   35s ⏱️ +3s
85 tests ±0  82 ✔️ ±0  3 💤 ±0  0 ±0 
86 runs  ±0  83 ✔️ ±0  3 💤 ±0  0 ±0 

Results for commit 6359560. ± Comparison against base commit d25edfe.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 8, 2023

Codecov Report

Merging #265 (6359560) into main (d25edfe) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #265   +/-   ##
=========================================
  Coverage     62.23%   62.23%           
  Complexity      254      254           
=========================================
  Files            47       47           
  Lines          1046     1046           
  Branches        130      130           
=========================================
  Hits            651      651           
  Misses          344      344           
  Partials         51       51           

Impacted file tree graph

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jeromy-cannon jeromy-cannon marked this pull request as ready for review August 8, 2023 16:13
@jeromy-cannon jeromy-cannon merged commit fb73b5d into main Aug 8, 2023
@jeromy-cannon jeromy-cannon deleted the 00210-partial-tmplt-namespace-prefix branch August 8, 2023 17:07
swirlds-automation added a commit that referenced this pull request Aug 9, 2023
## [0.6.0](v0.5.0...v0.6.0) (2023-08-09)

### Features

* convert chart tests from the custom bash script to be BATS unit tests ([#256](#256)) ([0bcdfcb](0bcdfcb))
* update partial templates to match naming conventions and prefix with fullstack namespace ([#265](#265)) ([fb73b5d](fb73b5d))

### Bug Fixes

* correct KeyValuePair equals and add coverage for ServiceLocator ([#257](#257)) ([5b17978](5b17978))
* default tag is not set properly for proxy containers ([#266](#266)) ([deabd16](deabd16))
* enable overriding individual properties for sidecars ([#250](#250)) ([7d5a4e1](7d5a4e1))
* only allow jrs profile during node setup ([#249](#249)) ([dd326c1](dd326c1))
* typo in the semantic release config preventing the updates to Chart.yaml from being committed ([#252](#252)) ([02a576b](02a576b))
* update verification script so that CI pipeline fails if node fails to start ([#254](#254)) ([7f051c0](7f051c0))
@swirlds-automation
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Charts[Network Node]: Ensure all named partial templates use the standard namespace prefix

3 participants