Skip to content

Fix flatbuffers conversion during Python init#112

Merged
litvand merged 7 commits intodev/python-fixesfrom
al/py-init-fbs
Jan 6, 2022
Merged

Fix flatbuffers conversion during Python init#112
litvand merged 7 commits intodev/python-fixesfrom
al/py-init-fbs

Conversation

@litvand
Copy link
Copy Markdown
Contributor

@litvand litvand commented Dec 20, 2021

🌟 What is the purpose of this PR?

Python init PR 1

🔗 Related links

🔍 What does this change?

  • Re-enables Python runner
  • Fixes dataset batch loading in Python runner
  • Fixes flatbuffers 'Serialized' loading in Python runner

🛡 Tests

  • ✅ Manual Tests

❓ How to test this?

  1. Run any experiment.
  2. The Python runner should start and reach package loading.

Copy link
Copy Markdown
Contributor

@Alfred-Mountfield Alfred-Mountfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the partial enabling of the Python runner cause any problems with Javascript sims?

Just want to make sure we don't need to feature-flag this work until completion / do it in a dev branch or something.

Comment thread packages/engine/src/worker/mod.rs Outdated
Comment thread packages/engine/src/worker/mod.rs Outdated
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 6, 2022

CLA assistant check
All committers have signed the CLA.

@litvand litvand closed this Jan 6, 2022
@litvand litvand reopened this Jan 6, 2022
@litvand litvand changed the base branch from main to dev/python-fixes January 6, 2022 14:19
@github-actions github-actions bot added the area/content > hash.ai Affects the `hash.ai` informational site (content) label Jan 6, 2022
# Geospatial

The geospatial viewer provides a realtime view of a simulation running inside any geographic area — a neighborhood, a city, a country, or the whole world. It's great for visualizing simulations in which agents occupy a position on a map. Take a look at the [City Infection Model](/@hash/city-infection-model-with-vaccine) for an example simulation using the geospatial viewer.
The geospatial viewer provides a realtime view of a simulation running inside any geographic area — a neighborhood, a city, a country, or the whole world. It's great for visualizing simulations in which agents occupy a position on a map. Take a look at the [City Infection Model](https://core.hash.ai/@hash/city-infection-model-with-vaccine/stable?view=geo) for an example simulation using the geospatial viewer.
Copy link
Copy Markdown
Contributor

@Alfred-Mountfield Alfred-Mountfield Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the target branch isn't quite up to date on main

@litvand litvand merged commit b8274df into dev/python-fixes Jan 6, 2022
@litvand litvand deleted the al/py-init-fbs branch January 6, 2022 14:54
@litvand litvand mentioned this pull request Jan 26, 2022
Alfred-Mountfield pushed a commit that referenced this pull request Mar 23, 2022
* Fix flatbuffers conversion during Python init (#112)

* Fix package loading in Python runner (#113)

* Fix line numbers in Python tracebacks (#114)

* Fix behavior execution package Python component init (#115)

* Fix messages package Python experiment init (#116)

* Fix Python runner init (#117)

* Fix Python execution (#214)

* Log received inbound messages in Python process

* Fix Python state snapshot sync

* Display flatc errors from genfbs.py

* Fix conflicting TaskMsg flatbuffers definitions

* Propagate JS inbound message receive errors

* Fix Python state interim sync

* Fix Python task execution

* Make Python error handling more consistent; update docstrings

* Enabling Python tests

* Adding Python setup to CI

* Building before setting up Python script in CI

* Only running Python setup from the root and building all

* Running python setup from the package root

* Changing python setup run cmd

* Specifying server in cargo build in workflow

* Running tests from the right cwd

* Debugging the contents of the github workspace

* Fix Python `context.step()`

* Changing output format on integration tests

* Fix a variety of Errors around the Python runner (#254)

* Fixed init tests

* Made behavior index private, and fixed incrementing with multi-language, and fixed access in Python

* Fixing behavior index field access in python to use full loading

* Fix receiving Python errors in Rust

* Removing outdated `server` reference from Rust workflow

* Fixing optional GroupIndex on TaskMsg

* Programmatically search for libhash_engine_lib.so

* Run state interim sync before `run_task` in Python

* Disable native python logging

* Fix outbound group index deserialization

* Fix Python integration tests implementation

* Properly check for metaversion in python

* Fix neighbor access in Python

* Disable behavior reusing

* Support index notation for Python

* Implement state sync for Python

Co-authored-by: litvand <8569704+litvand@users.noreply.github.com>
Co-authored-by: Alfred Mountfield <am@hash.ai>
Co-authored-by: Tim Diekmann <tim.diekmann@3dvision.de>
@vilkinsons vilkinsons added category/enhancement New feature or request and removed C-enhancement labels Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/content > hash.ai Affects the `hash.ai` informational site (content) category/enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

5 participants