Skip to content

Fix Python runner init#117

Merged
litvand merged 2 commits intodev/python-fixesfrom
al/fix-python-init
Jan 10, 2022
Merged

Fix Python runner init#117
litvand merged 2 commits intodev/python-fixesfrom
al/fix-python-init

Conversation

@litvand
Copy link
Copy Markdown
Contributor

@litvand litvand commented Dec 20, 2021

🌟 What is the purpose of this PR?

Python init PR #6

🔗 Related links

🔍 What does this change?

  • Temporarily ignores (aside from termination) inbound messages to the Python runner -- they are not forwarded as nng messages
  • (Did merge with main)

🛡 Tests

  • ✅ Manual Tests

❓ How to test this?

  1. Run any experiment with packages that have Python components
  2. The experiment should work as long as no tasks are actually sent to the Python runner to be executed

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Dec 20, 2021

This pull request introduces 1 alert and fixes 1 when merging 4102aec into 67a8cd8 - view on LGTM.com

new alerts:

  • 1 for Unreachable code

fixed alerts:

  • 1 for Syntax error

Copy link
Copy Markdown
Contributor

@Alfred-Mountfield Alfred-Mountfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until #116 is merged and this branch is rebased for easier review

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 6, 2022

CLA assistant check
All committers have signed the CLA.

@litvand litvand force-pushed the al/fix-python-init branch from 4102aec to f657e82 Compare January 7, 2022 13:53
@github-actions github-actions bot added the area/content > hash.ai Affects the `hash.ai` informational site (content) label Jan 7, 2022
@litvand litvand changed the base branch from main to dev/python-fixes January 7, 2022 13:55
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 7, 2022

This pull request introduces 1 alert and fixes 1 when merging f657e82 into f7bf804 - view on LGTM.com

new alerts:

  • 1 for Unreachable code

fixed alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 7, 2022

This pull request introduces 1 alert when merging f657e82 into 11d2945 - view on LGTM.com

new alerts:

  • 1 for Unreachable code

@github-actions github-actions bot removed the area/content > hash.ai Affects the `hash.ai` informational site (content) label Jan 10, 2022
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 10, 2022

This pull request introduces 1 alert when merging 03b1c4d into 11d2945 - view on LGTM.com

new alerts:

  • 1 for Unreachable code

Comment thread packages/engine/src/worker/runner/python/mod.rs
Comment thread packages/engine/src/worker/runner/python/runner.py
@litvand litvand merged commit 64909b4 into dev/python-fixes Jan 10, 2022
@litvand litvand deleted the al/fix-python-init branch January 10, 2022 15:32
@litvand litvand mentioned this pull request Jan 26, 2022
Alfred-Mountfield pushed a commit that referenced this pull request Mar 23, 2022
* Fix flatbuffers conversion during Python init (#112)

* Fix package loading in Python runner (#113)

* Fix line numbers in Python tracebacks (#114)

* Fix behavior execution package Python component init (#115)

* Fix messages package Python experiment init (#116)

* Fix Python runner init (#117)

* Fix Python execution (#214)

* Log received inbound messages in Python process

* Fix Python state snapshot sync

* Display flatc errors from genfbs.py

* Fix conflicting TaskMsg flatbuffers definitions

* Propagate JS inbound message receive errors

* Fix Python state interim sync

* Fix Python task execution

* Make Python error handling more consistent; update docstrings

* Enabling Python tests

* Adding Python setup to CI

* Building before setting up Python script in CI

* Only running Python setup from the root and building all

* Running python setup from the package root

* Changing python setup run cmd

* Specifying server in cargo build in workflow

* Running tests from the right cwd

* Debugging the contents of the github workspace

* Fix Python `context.step()`

* Changing output format on integration tests

* Fix a variety of Errors around the Python runner (#254)

* Fixed init tests

* Made behavior index private, and fixed incrementing with multi-language, and fixed access in Python

* Fixing behavior index field access in python to use full loading

* Fix receiving Python errors in Rust

* Removing outdated `server` reference from Rust workflow

* Fixing optional GroupIndex on TaskMsg

* Programmatically search for libhash_engine_lib.so

* Run state interim sync before `run_task` in Python

* Disable native python logging

* Fix outbound group index deserialization

* Fix Python integration tests implementation

* Properly check for metaversion in python

* Fix neighbor access in Python

* Disable behavior reusing

* Support index notation for Python

* Implement state sync for Python

Co-authored-by: litvand <8569704+litvand@users.noreply.github.com>
Co-authored-by: Alfred Mountfield <am@hash.ai>
Co-authored-by: Tim Diekmann <tim.diekmann@3dvision.de>
@vilkinsons vilkinsons added category/enhancement New feature or request and removed C-enhancement labels Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category/enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

5 participants