[BE] Gracefully handle redis disconnects - #198
Merged
Merged
Conversation
In packages/hash/realtime/src/index.ts:27-95, packages/hash/realtime/src/index.ts:27-82, packages/hash/realtime/src/index.ts:27-107:Untrusted input concatinated with raw SQL query can result in SQL Injection. Click a link below to tell your Security Team if this comment was: Found by ajinabraham.njsscan.sql_injection.node_sqli_injection in Security Policy. |
Contributor
|
I can confirm I've seen this issue and it's very annoying – thank you for aiming to fix it! Will take a look shortly. |
nathggns
approved these changes
Jan 21, 2022
nathggns
left a comment
Contributor
There was a problem hiding this comment.
In a bad position in my local setup right now to review functionality, but the code looks great and it should solve the issue from what I can tell.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Gracefully handle redis disconnects to not crash the app and let it reconnect.
🔍 What does this change?
setIntervalwhich would try to access an undefined object after a redis disconnect and crash the app🔗 Related links
❓ How to test this?
Turn off the redis docker container while the app is running and see those events in the log, then turn it back on and see the app reconnects to redis, recovers and continues to work as expected.