Conversation
Contributor
nshlapo
commented
May 20, 2021
nshlapo
commented
- Bringing the Python standard library to parity with the TypeScript library.
- Adding tests for all new Python functions
- Small improvements in code clarity for TypeScript library.
- Larger rework of the TypeScript neighbors/neighborsInRadius function to use distance functions from spatial/
eadanfahey
reviewed
May 20, 2021
ghabs
approved these changes
May 20, 2021
Contributor
ghabs
left a comment
ghabs
left a comment
There was a problem hiding this comment.
works for me, thanks! LGTM though Eadan's suggestions seem worth implementing.
Contributor
|
@nshlapo I left some comments saying that |
|
This pull request introduces 2 alerts when merging 71f3c68 into eed7ea1 - view on LGTM.com new alerts:
|
eadanfahey
approved these changes
May 21, 2021
kube
added a commit
that referenced
this pull request
Apr 14, 2026
… reviews Decompose the monolithic chart effect into 4 single-responsibility effects: - Effect 1: create/destroy uPlot on structural changes only - Effect 2: sync container size via useElementSize hook - Effect 3: stream data with setData(data, false) - Effect 4: playhead redraw Derived state replaces imperative plumbing: - useElementSize(ref) replaces getBoundingClientRect + inline ResizeObserver - useStableCallback(onScrub) keeps a stable identity, fixing chart recreation on every streaming update (AI review #1) - Extract attachRulerScrubbing() helper with cached overRect AI review fixes: - #1 onScrub instability causing chart recreation — useStableCallback - #2 missing placeMeta in streaming effect deps - #3 fill color hex assumption — use color-mix(in srgb) instead - #4 y-scale [0,0] when all values zero — Math.max(1, max * 1.05) - #7 playhead line offset not dpr-scaled — tipY - 4 * dpr Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.