Skip to content

FE-583: fix transition text wrapping#8629

Merged
alex-e-leon merged 4 commits intomainfrom
FE-583-fix-transition-text-wrapping
Apr 14, 2026
Merged

FE-583: fix transition text wrapping#8629
alex-e-leon merged 4 commits intomainfrom
FE-583-fix-transition-text-wrapping

Conversation

@alex-e-leon
Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

  • Fixes text wrapping in transition nodes (maxWidth: 100% was missing)
  • Also cleans up the styling + html for classic nodes - removing unnecessary extra divs and css.
  • Removes opacity from place nodes.

Note I've skipped adding a changeset, as the changeset for the previous PR covering this covers these changes.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

The changes in this PR:

  • are internal and do not require a docs change

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Apr 14, 2026 0:13am
petrinaut Ready Ready Preview, Comment Apr 14, 2026 0:13am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
hashdotdesign Ignored Ignored Preview Apr 14, 2026 0:13am
hashdotdesign-tokens Ignored Ignored Preview Apr 14, 2026 0:13am

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 14, 2026

PR Summary

Low Risk
Low risk UI-only styling/layout adjustments to node rendering; main risk is minor visual regressions (spacing, truncation, colors) in the SDCPN editor.

Overview
Fixes label layout issues in classic transition nodes by constraining text (maxWidth: 100%) and switching to ellipsis/2-line clamping, plus slightly reducing transition box padding.

Cleans up classic place node markup by removing extra wrapper elements and moving flex layout concerns onto the circle container; also adjusts place background colors to remove opacity (including the non-classic PlaceNode) and tweaks the classic place type-color lightening.

Reviewed by Cursor Bugbot for commit 618a386. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team labels Apr 14, 2026
@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Apr 14, 2026

🤖 Augment PR Summary

Summary: Adjusts Classic SDCPN node styling to improve label wrapping/clamping and simplify markup.

Changes:

  • Simplifies ClassicPlaceNode DOM structure and moves spacing/layout to the outer circle container.
  • Updates Classic place background colors (removing alpha) and tweaks type-color lightening.
  • Updates ClassicTransitionNode label styling (max-width + clamping) and reduces box padding.
  • Removes opacity from modern PlaceNode background when a typeColor is present.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 618a386. Configure here.

Copy link
Copy Markdown
Collaborator

@kube kube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alex-e-leon alex-e-leon added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit 1074cf2 Apr 14, 2026
46 checks passed
@alex-e-leon alex-e-leon deleted the FE-583-fix-transition-text-wrapping branch April 14, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants