FE-620: DS icon component#8661
Conversation
PR SummaryMedium Risk Overview Updates the package build/demo pipeline to support importing Reviewed by Cursor Bugbot for commit 14d7e16. Bugbot is set up for automated code reviews on this repo. Configure here. |
🤖 Augment PR SummarySummary: Adds a new
🤖 Was this summary useful? React with 👍 or 👎 |
|
So, FTR I must say I'm not convinced Personally I’d strongly prefer something like:
|
|
Some context: Breaking Up with SVG-in-JS |
I 100% agree - I plan on implementing spriting down the line. I've used svgr for now because its much simpler to setup and get working, while I'm a little uncertain how the pipeline for spriting will work for consumers right now. My plan was once I've finished a couple of these components and got a consumer (likely petrinaut) actually consuming the icons properly to then come back and implement spriting so that I have a real consumer to test the spriting pipeline. |
What exactly do you mean by a manifest?
Agree - this is how the icon component works at the moment. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 41b4603. Configure here.
d75e252 to
0d49403
Compare
0d49403 to
14d7e16
Compare
Just a central definition of which icons should go in to the sprite |

🌟 What is the purpose of this PR?
Adds an Icon component to the DS. Once I've created a button component and updated petrinaut to use this component I may need to come back and update some properties.
Because we are using font awesome's pro icon set we can't re-export (or import) all of font-awesomes Icon set, so instead I've manually copied over the subset that we use. We also won't be able to allow users to select an icon in our UI's so we'll need to ban that ui pattern somehow.
Pre-Merge Checklist 🚀
This PR:
📜 Does this require a change to the docs?
The changes in this PR: