Skip to content

FE-774: add dialog to ds#8802

Merged
alex-e-leon merged 36 commits into
mainfrom
FE-774-add-dialog-to-ds
Jun 2, 2026
Merged

FE-774: add dialog to ds#8802
alex-e-leon merged 36 commits into
mainfrom
FE-774-add-dialog-to-ds

Conversation

@alex-e-leon
Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Adds a Dialog component to the design system

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Jun 2, 2026 12:43pm
hashdotdesign-tokens Ready Ready Preview, Comment Jun 2, 2026 12:43pm
petrinaut Ready Ready Preview, Comment Jun 2, 2026 12:43pm

@cursor
Copy link
Copy Markdown

cursor Bot commented Jun 1, 2026

PR Summary

Low Risk
New UI library surface and a minor breaking change to autoFocus typing; no auth, data, or production app logic in the diff.

Overview
Adds a new Dialog to @hashintel/ds-components, built on Ark UI with Dialog.Header, Dialog.Body, and Dialog.Footer, plus styling for sizes (xsxl, fullScreen), partitionedFooter / plain variants, loading overlay, configurable shouldCloseOn, focus refs, and stacked-dialog visuals (nested offset, non-cumulative backdrops). It is exported from the package and documented via a changeset and Ladle stories.

Button now allows aria-label as an alternative to tooltip/children (for icon-only close). SharedInputProps.autoFocus is simplified to boolean only; base-input drops the unused data-no-autofocus attribute.

Reviewed by Cursor Bugbot for commit 45bfeed. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/apps > hash.design Affects the `hash.design` design site (app) labels Jun 1, 2026
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Jun 1, 2026

🤖 Augment PR Summary

Summary: Adds a new Dialog component to the HASH design system, built on Ark UI and styled via Panda recipes.

Changes:

  • Introduced Dialog wrapper component with structured/custom header support, footer action areas, and optional loading overlay
  • Added Dialog sva recipe with slot styling, size variants, and header/padding variants
  • Added Ladle stories covering common configurations, sizing, overflow behavior, stacking, and close behaviors
  • Updated Button prop requirements to allow aria-label to satisfy the “must provide accessible content” constraint
  • Simplified shared input autoFocus typing and removed a data-no-autofocus attribute from BaseInput

Technical Notes: Dialog uses the portal container context so portalled content inherits scoped theme variables; close interactions are configured via shouldCloseOn.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 3 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread libs/@hashintel/ds-components/src/components/Dialog/dialog.tsx
Comment thread libs/@hashintel/ds-components/src/components/Dialog/dialog.tsx
Comment thread libs/@hashintel/ds-components/src/util/form-shared.ts
Comment thread libs/@hashintel/ds-components/src/components/Dialog/dialog.tsx Outdated
Comment thread libs/@hashintel/ds-components/src/main.ts
Comment thread libs/@hashintel/ds-components/src/components/Dialog/dialog.tsx
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 45bfeed. Configure here.

@alex-e-leon alex-e-leon added this pull request to the merge queue Jun 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 2, 2026
@alex-e-leon alex-e-leon added this pull request to the merge queue Jun 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 2, 2026
@alex-e-leon alex-e-leon added this pull request to the merge queue Jun 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 2, 2026
@alex-e-leon alex-e-leon added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit c39ede8 Jun 2, 2026
46 checks passed
@alex-e-leon alex-e-leon deleted the FE-774-add-dialog-to-ds branch June 2, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash.design Affects the `hash.design` design site (app) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants