FE-1158: Add boolean predicates to experiment metrics#8974
Draft
kube wants to merge 1 commit into
Draft
Conversation
Predicates are boolean-returning custom-code metrics evaluated per run: each run is tested every frame until the predicate first returns true, the time is recorded, and the run is not tested again. - Compile predicates through the HIR metric surface with a boolean return type (HirCompileOptions.metricReturnTypes), sharing the metric buffer ABI and LSP session validation. - Model predicate specs as a discriminated union member (MonteCarloPredicateSpec) travelling in-band in metricSpecs; runtimes split once via splitMonteCarloMetricSpecs. - Stream versioned predicate snapshots from the worker into a new predicates store on the experiment handle. - UI: Predicate toggle on custom-code experiment metrics; view-drawer boxes show floored true-percentage, run counts, and the median simulation time at which runs first satisfied the predicate. - Cover the compiled boolean artifact path end-to-end against real frame buffers, and update the user docs and BUFFER_ABI.md.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
area/infra
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
🔗 Related links
🚫 Blocked by
🔍 What does this change?
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
turbo.json's have been updated to reflect this🐾 Next steps
🛡 What tests cover this?
❓ How to test this?
📹 Demo