FE-1637: Show read-only property values as text instead of disabled inputs - #9596
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
830e308 to
3536e65
Compare
3536e65 to
b6c687f
Compare
PR SummaryLow Risk Overview A new Properties panels for places, arcs (type/weight, shared type labels), differential equations (associated type), and component instances (name) adopt the same pattern. Toggles, checkboxes, and list-style editors are unchanged. Preview docs and a patch changeset describe the behavior; Reviewed by Cursor Bugbot for commit ffdea8a. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
🟡 Changes recommended
Several simple fields remain disabled controls, and read-only transitions introduce whitespace, validation, and textarea-sizing regressions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates Petrinaut’s properties panel to present read-only values as text rather than disabled controls.
Changes:
- Adds a shared
PropertyValuecomponent and tests. - Applies text rendering to names, descriptions, selected types, and arc properties.
- Updates preview documentation and package changeset.
File summaries
| File | Description |
|---|---|
.changeset/readonly-property-values-as-text.md |
Records the user-facing change. |
libs/@hashintel/petrinaut/docs/preview.md |
Documents read-only value presentation. |
.../components/property-value.tsx |
Adds editable/read-only rendering. |
.../components/property-value.test.tsx |
Tests rendering modes and empty values. |
.../components/draft-field-input.tsx |
Uses text rendering for draft fields. |
.../components/description-field.tsx |
Uses text rendering for descriptions. |
.../place-properties/subviews/main.tsx |
Updates place name and token type. |
.../differential-equation-properties/subviews/main.tsx |
Updates associated type display. |
.../component-instance-properties/subviews/main.tsx |
Updates instance name display. |
.../arc-properties/main.tsx |
Updates arc type and weight display. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 4
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b6c687f. Configure here.
b6c687f to
a6ca977
Compare
|
All four addressed in Description height after editing resumes (also raised by Bugbot): real. The sizing Stale draft error beside the canonical value: real, and it reached three places.
Docs broader than the behaviour: correct. The sentence in |
20b84db to
ffdea8a
Compare

Summary
Before this PR, a read-only net still rendered every property value in the control that edits it, greyed out. A name arrived as a disabled text box, a description as a disabled textarea, and the field labels dimmed along with them, so the values a reader came for were the lowest-contrast text on the panel. Two fields in the arc panel already sidestepped this and printed their value as text.
The properties panel now renders read-only values the way those two arc fields do: the value as text, at full contrast, under a label that no longer greys out. This reaches the embedded Preview, the website's full example view, and the editor whenever the net is read-only, which includes Simulate mode and any live simulation.
Links
Changes
Shared
PropertyValue, wrapping one field's editing controlDraftFieldInputand the description field render through itPanels
Known issues
Test coverage
property-value.test.tsx:@hashintel/petrinautunit suiteHow to test