Backport #12054: Fix runRuleDynDepsCmd binary format mismatch#12099
Merged
Conversation
This change fixes the binary format mismatch between the build rules producer and the consumer, resulting in `Missing ByteString argument in 'ruleExecCmd'` error during builds. When a hook creates a dynamic hook with a command for discovering dynamic dependencies, the hook creates a result of type ([Dependency], LBS.ByteString), but the consumer decodes it as Maybe ([Dependency], LBS.ByteString). Added a test case to SetupHooksNonHs that covers this scenario. Added changelog entry. Fixes #12053 (cherry picked from commit ae71634)
6 tasks
Mikolaj
approved these changes
Jul 6, 2026
Contributor
Author
Merge Queue Status
This pull request spent 1 hour 59 minutes 36 seconds in the queue, including 1 hour 48 minutes 51 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the binary format mismatch between the build rules producer and the consumer, resulting in
Missing ByteString argument in 'ruleExecCmd'error during builds. When a hook creates a dynamic hook with a command for discovering dynamic dependencies, the hook creates a result of type([Dependency], LBS.ByteString), but the consumer decodes it asMaybe ([Dependency], LBS.ByteString).Added a test case to SetupHooksNonHs that covers this scenario.
Fixes #12053
Template Α: This PR modifies behaviour or interface
significance: significantin the changelog file.This is an automatic backport of pull request #12054 done by [Mergify](https://mergify.com).