Skip to content

TSK-421: Improve Core testing and coverage#2387

Merged
disant1 merged 5 commits into
hcengineering:mainfrom
disant1:tsk-421-improve-core-test-coverage
Nov 23, 2022
Merged

TSK-421: Improve Core testing and coverage#2387
disant1 merged 5 commits into
hcengineering:mainfrom
disant1:tsk-421-improve-core-test-coverage

Conversation

@disant1

@disant1 disant1 commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@disant1
disant1 marked this pull request as draft November 21, 2022 06:51
@disant1
disant1 requested a review from haiodo November 21, 2022 10:43
Comment thread packages/core/src/__tests__/client.test.ts Outdated
Comment thread packages/core/src/__tests__/client.test.ts Outdated
Comment thread packages/core/src/__tests__/client.test.ts Outdated
@disant1
disant1 requested a review from haiodo November 22, 2022 02:44
@disant1 disant1 changed the title TSK-421: Improve coverage for clients.ts TSK-421: Improve Core testing and coverage Nov 22, 2022
@disant1
disant1 marked this pull request as ready for review November 23, 2022 02:19
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
@disant1
disant1 merged commit 2238986 into hcengineering:main Nov 23, 2022
@disant1
disant1 deleted the tsk-421-improve-core-test-coverage branch November 24, 2022 02:04
mrsadman99 pushed a commit that referenced this pull request Nov 24, 2022
* main:
  TSK-397: Fixed time report round (#2389)
  TSK-421: Improve Core testing and coverage (#2387)
  Fixes to collaborator and documents (#2394)
  Add sprint members (#2392)
  TSK-420: Fixed time report placeholders (#2390)
  HR: Update Schedule layout. Fix tooltip and popup. (#2388)
  TSK-433 Allow to send attachments without text

Signed-off-by: Anton Brechka <anton.brechka@xored.com>
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
* Improve coverage for clients.ts

Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>

* Refactor and fix comments

Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>

* Fix typo

Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>

* Fix formatting

Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>

* Added 2 tests for hierarchy.ts

Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>

Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants