Skip to content

Improve Requests#2492

Merged
BykhovDenis merged 3 commits into
mainfrom
improve-requests
Jan 6, 2023
Merged

Improve Requests#2492
BykhovDenis merged 3 commits into
mainfrom
improve-requests

Conversation

@haiodo

@haiodo haiodo commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

Signed-off-by: Andrey Sobolev haiodo@gmail.com

Contribution checklist

Brief description

  1. Hide second comment input line.
  2. Add presenter.
  3. Fix UserBox list to show one person and change readonly logic, allow to click to show values for readonly.
  4. Fix collaboration editor layout.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

1. Hide second comment input line.
2. Add presenter.
3. Fix UserBox list to show one person and change readonly logic, allow to click to show values for readonly.
4. Fix collaboration editor layout.

Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo
haiodo requested a review from BykhovDenis January 5, 2023 17:42
haiodo added 2 commits January 6, 2023 13:23
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@BykhovDenis
BykhovDenis merged commit 3657199 into main Jan 6, 2023
@BykhovDenis
BykhovDenis deleted the improve-requests branch January 6, 2023 07:31
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants