Skip to content

Set front url metadata for SES#2555

Merged
haiodo merged 2 commits into
mainfrom
pass_front_url
Jan 29, 2023
Merged

Set front url metadata for SES#2555
haiodo merged 2 commits into
mainfrom
pass_front_url

Conversation

@BykhovDenis

Copy link
Copy Markdown
Member

Signed-off-by: Denis Bykhov bykhov.denis@gmail.com

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
BykhovDenis requested a review from haiodo January 28, 2023 15:29
@BykhovDenis BykhovDenis self-assigned this Jan 28, 2023

@haiodo haiodo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tests/docker-compose.yaml and dev/docker-compose.yaml need to be updated as well.

Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@haiodo
haiodo merged commit b8fd815 into main Jan 29, 2023
@haiodo
haiodo deleted the pass_front_url branch January 29, 2023 15:32
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants