Skip to content

Selecting Activity parameters#2576

Merged
haiodo merged 7 commits into
mainfrom
fix-604
Feb 3, 2023
Merged

Selecting Activity parameters#2576
haiodo merged 7 commits into
mainfrom
fix-604

Conversation

@SasLord

@SasLord SasLord commented Feb 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Signed-off-by: Alexander Platov sas_lord@mail.ru

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues
TSK-604

@SasLord
Selecting Activity parameters
aefc4db 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@SasLord
Fix
c1afc1f 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
haiodo
haiodo reviewed Feb 2, 2023
View reviewed changes
Comment thread plugins/activity-resources/src/components/Activity.svelte Outdated
haiodo
haiodo reviewed Feb 2, 2023
View reviewed changes
Comment thread plugins/activity-resources/src/components/Activity.svelte Outdated
@SasLord
Changed the filtering
803106e 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@SasLord
Anchored popup
fcb4a58 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@SasLord
Patch
74cf9a6 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@SasLord
Fix Activity layout
38ddd46 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
haiodo
haiodo suggested changes Feb 2, 2023
View reviewed changes
Comment thread plugins/activity-resources/src/components/Activity.svelte Outdated
@SasLord
Changed the filtering
e13bb7f 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@SasLord
SasLord requested a review from haiodo February 2, 2023 19:36
@haiodo
haiodo merged commit 8b12b64 into main Feb 3, 2023
@haiodo
haiodo deleted the fix-604 branch February 3, 2023 02:54
ThetaDR pushed a commit that referenced this pull request Feb 6, 2023
@SasLord @ThetaDR
Selecting Activity parameters (#2576)
ca6d31c 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
@SasLord
Selecting Activity parameters (hcengineering#2576)
1c1e36b 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@haiodo haiodo haiodo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SasLord @haiodo