Skip to content

Fix Bitrix attachments#2683

Merged
haiodo merged 2 commits into
mainfrom
fix-multi-file-attachments
Feb 24, 2023
Merged

Fix Bitrix attachments#2683
haiodo merged 2 commits into
mainfrom
fix-multi-file-attachments

Conversation

@haiodo

@haiodo haiodo commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo
haiodo requested a review from BykhovDenis February 23, 2023 08:54
@haiodo
haiodo force-pushed the fix-multi-file-attachments branch from 2d9ce9a to ae4eff9 Compare February 23, 2023 10:52
@haiodo
Fix Bitrix attachments
29d367e 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo
haiodo force-pushed the fix-multi-file-attachments branch from ae4eff9 to 29d367e Compare February 23, 2023 10:53
@haiodo
haiodo marked this pull request as draft February 24, 2023 05:08
@haiodo
haiodo force-pushed the fix-multi-file-attachments branch from 8ba45e7 to dac88f3 Compare February 24, 2023 07:10
@haiodo
Fix attached document creation
32bb2b2 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo
haiodo force-pushed the fix-multi-file-attachments branch from dac88f3 to 32bb2b2 Compare February 24, 2023 07:43
@haiodo
haiodo marked this pull request as ready for review February 24, 2023 07:47
@haiodo
haiodo merged commit 96f0fef into main Feb 24, 2023
@haiodo
haiodo deleted the fix-multi-file-attachments branch February 24, 2023 08:04
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
@haiodo
Fix Bitrix attachments (hcengineering#2683)
24eefe0 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haiodo @BykhovDenis