Skip to content

Make visibleIf async in SpecialNavModel#2684

Merged
haiodo merged 2 commits into
mainfrom
make-visible-if-async-special
Feb 27, 2023
Merged

Make visibleIf async in SpecialNavModel#2684
haiodo merged 2 commits into
mainfrom
make-visible-if-async-special

Conversation

@denis-bunakalya

@denis-bunakalya denis-bunakalya commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Denis Bunakalya <denis.bunakalya@xored.com>
Comment thread plugins/workbench/src/index.ts
Signed-off-by: Denis Bunakalya <denis.bunakalya@xored.com>
@haiodo
haiodo merged commit 8f0f69f into main Feb 27, 2023
@haiodo
haiodo deleted the make-visible-if-async-special branch February 27, 2023 03:03
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Denis Bunakalya <denis.bunakalya@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants