Skip to content

Update StepsDialog steps switching#2692

Merged
haiodo merged 3 commits into
mainfrom
inner-ref-for-component
Feb 28, 2023
Merged

Update StepsDialog steps switching#2692
haiodo merged 3 commits into
mainfrom
inner-ref-for-component

Conversation

@ghost

@ghost ghost commented Feb 28, 2023

Copy link
Copy Markdown

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Sergei Ogorelkov added 2 commits February 28, 2023 14:03
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Replaced "model.onDone()" with direct component function call

Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
@ghost
ghost requested review from BykhovDenis and haiodo February 28, 2023 08:06
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
@haiodo
haiodo merged commit ad4d65a into main Feb 28, 2023
@haiodo
haiodo deleted the inner-ref-for-component branch February 28, 2023 18:37
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant