Skip to content

Team members#2712

Merged
haiodo merged 1 commit into
mainfrom
team_members
Mar 6, 2023
Merged

Team members#2712
haiodo merged 1 commit into
mainfrom
team_members

Conversation

@BykhovDenis

Copy link
Copy Markdown
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/TSK-771
A list of closed updated issues

Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
BykhovDenis requested a review from haiodo March 6, 2023 09:48
@BykhovDenis BykhovDenis self-assigned this Mar 6, 2023
<Label label={tracker.string.Members} />
</div>
<AccountArrayEditor
value={members}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to disallow to remove current member from list.

@haiodo
haiodo merged commit ca002b4 into main Mar 6, 2023
@haiodo
haiodo deleted the team_members branch March 6, 2023 15:44
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants