Skip to content

TSK-1013: add position field to Employee#2874

Merged
haiodo merged 2 commits into
mainfrom
TSK-1013
Apr 4, 2023
Merged

TSK-1013: add position field to Employee#2874
haiodo merged 2 commits into
mainfrom
TSK-1013

Conversation

@ThetaDR

@ThetaDR ThetaDR commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

image

https://front.hc.engineering/workbench/platform/tracker/TSK-1013

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
ThetaDR requested a review from haiodo April 3, 2023 15:23
Comment thread plugins/contact-resources/src/components/EditEmployee.svelte Outdated

@haiodo haiodo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need position in middle panel?

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
ThetaDR requested a review from haiodo April 4, 2023 06:06
@haiodo
haiodo merged commit c6fc35c into main Apr 4, 2023
@haiodo
haiodo deleted the TSK-1013 branch April 4, 2023 08:39
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants