TSK-1046 Gmail/telegram messages collaborators TSK-1097 Inbox scroll#2928
Merged
Conversation
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
BykhovDenis
changed the title
haiodo
reviewed
Apr 10, 2023
| providerQuery.query(contact.class.ChannelProvider, { _id: value.provider }, (res) => ([provider] = res)) | ||
| let target: Contact | undefined | ||
| const query = createQuery() | ||
| query.query(contact.class.Contact, { _id: value.attachedTo as Ref<Contact> }, (res) => ([target] = res)) |
Contributor
There was a problem hiding this comment.
Do we need $: here? Since value is passed here as export let variable?
haiodo
reviewed
Apr 10, 2023
| @@ -0,0 +1,44 @@ | |||
| <!-- | |||
| // Copyright © 2020, 2021 Anticrm Platform Contributors. | |||
| // Copyright © 2021 Hardcore Engineering Inc. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright © 2021 Hardcore Engineering Inc. | |
| // Copyright © 2023 Hardcore Engineering Inc. |
haiodo
reviewed
Apr 10, 2023
| const result: Tx[] = [] | ||
|
|
||
| if (uTx.operations.$inc?.items !== undefined) { | ||
| const doc = (await control.findAll(uTx.objectClass, { _id: uTx.objectId }, { limit: 1 }))[0] |
Contributor
There was a problem hiding this comment.
Should we have some standalone logic in notification server plugin? and provide this information as Mixin for Classes?
haiodo
approved these changes
Apr 10, 2023
MichaelUray
pushed a commit
to MichaelUray/huly-platform
that referenced
this pull request
Jul 9, 2026
…cengineering#2928) Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution checklist
Brief description
Checklist
Related issues
https://front.hc.engineering/workbench/platform/tracker/TSK-1046
https://front.hc.engineering/workbench/platform/tracker/TSK-1097
A list of closed updated issues