[TSK-1304] Fix active viewlet if viewlet list is empty#3043
Merged
Conversation
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
haiodo
reviewed
Apr 21, 2023
| setActiveViewletId(viewlet._id) | ||
|
|
||
| if (viewlet) { | ||
| setActiveViewletId(viewlet._id) |
Contributor
There was a problem hiding this comment.
@BykhovDenis Should it be set to undefined in this case?
Member
There was a problem hiding this comment.
I think we always should have least one viewlet
Contributor
Author
There was a problem hiding this comment.
viewlets are [] by default. So, we don't have viewlets until the viewlets request is completed.
Contributor
There was a problem hiding this comment.
Should it be better to check for viewlets length before calling update in this case?
Contributor
Author
There was a problem hiding this comment.
Anyway, I think it's better to move this func to some util to avoid duplication throughout the project.
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com> # Conflicts: # plugins/tracker-resources/src/components/templates/IssueTemplatesView.svelte
haiodo
approved these changes
Apr 24, 2023
MichaelUray
pushed a commit
to MichaelUray/huly-platform
that referenced
this pull request
Jul 9, 2026
…#3043) Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution checklist
Brief description
Checklist
Related issues
TSK-1304