Skip to content

TSK-1311: add editors for String and Number#3056

Merged
haiodo merged 4 commits into
mainfrom
TSK-1311
Apr 25, 2023
Merged

TSK-1311: add editors for String and Number#3056
haiodo merged 4 commits into
mainfrom
TSK-1311

Conversation

@ThetaDR

@ThetaDR ThetaDR commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/TSK-1311
A list of closed updated issues

@ThetaDR
ThetaDR requested a review from BykhovDenis April 24, 2023 12:51
@ThetaDR
ThetaDR marked this pull request as draft April 24, 2023 13:19
ThetaDR added 2 commits April 25, 2023 16:05
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
ThetaDR marked this pull request as ready for review April 25, 2023 11:29
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo
haiodo merged commit 8e389c2 into main Apr 25, 2023
@haiodo
haiodo deleted the TSK-1311 branch April 25, 2023 16:14
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants