Skip to content

[TSK-1338] Update issue filters order#3141

Merged
haiodo merged 10 commits into
mainfrom
filters-order
May 5, 2023
Merged

[TSK-1338] Update issue filters order#3141
haiodo merged 10 commits into
mainfrom
filters-order

Conversation

@s0gorelkov

@s0gorelkov s0gorelkov commented May 4, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Also fixed a bug with duplicated filters for collection attributes such as "labels"

Screenshot 2023-05-04 at 17 54 09

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

TSK-1338

s0gorelkov added 5 commits May 4, 2023 17:48
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
@s0gorelkov
s0gorelkov requested review from BykhovDenis and haiodo May 4, 2023 13:57
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
Comment thread models/tracker/src/index.ts Outdated
'modifiedOn',
'modifiedBy'
],
ignoreKeys: ['number', 'estimation', 'attachedTo', 'space']

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need ignore hidden fields. Also 'space' filter here is good especially for 'my issues' mode

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no hidden fields I think. If I remove any key from this array, the filter appears in the filter list.
Thanks for note about "space" - removed.

): void {
const ignoreKeys = new Set(mixin.ignoreKeys ?? [])

if (mixin.strict) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is strict we should don't try build keys from hierarchy (desc and asc mixins)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

s0gorelkov added 4 commits May 5, 2023 10:33
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
@haiodo
haiodo merged commit 1362b55 into main May 5, 2023
@haiodo
haiodo deleted the filters-order branch May 5, 2023 11:12
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants