[TSK-1374] Restrict "ValueFilter" searchable types#3148
Merged
Conversation
Now the search can only be performed for strings and numbers Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
BykhovDenis
approved these changes
May 5, 2023
haiodo
reviewed
May 5, 2023
|
|
||
| // TODO: remove "TypeString" from search types after | ||
| // a separate filter for strings is implemented | ||
| $: isSearchable = [core.class.TypeNumber, core.class.TypeString].includes(filter.key.attribute.type._class) |
Contributor
There was a problem hiding this comment.
We need Enums's here for long categories, but we will loose it. Should we better control it with some mixin?
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
haiodo
approved these changes
May 10, 2023
MichaelUray
pushed a commit
to MichaelUray/huly-platform
that referenced
this pull request
Jul 9, 2026
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the search can only be performed for strings and numbers
Contribution checklist
Brief description
Checklist
Related issues
TSK-1374